Add parallel arrays shape for dictionaries and hashsets - #152
Open
ero-qt wants to merge 26 commits into
Open
Conversation
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #151.
Part of #149.
The oldest Mono Corlib (Unity 5.6 era, net20) lays dictionaries and hashsets out as parallel arrays instead of one entries array:
linkSlots/keySlots/valueSlots/touchedSlotson the dictionary,links/slots/touchedon the set.get_dictionary_offsetsandget_hash_set_offsetsresolve that shape too now, and the same read calls read it: walk the links up to the high-water mark, take the indices whose stored hash carries the live flag, and read the key and value arrays at those indices. TheLinkclass says which of its two ints is the hash, so either order works.Nothing changes on the surface, the offsets types just carry a shape inside now.