-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Low Quality Image Placeholder #2558
base: v6
Are you sure you want to change the base?
Conversation
Apologies, this took a lot longer than I expected. Life gets in the way sometimes, I'm sure you can relate... |
Hi, amazing piece of work!
Yep, currently feeling like I have been hit truck. Just got Covid. None the less, I don't know if you have been following Lychee lately, but we are close to releasing a v6 which will drop all the Livewire crap for a Vue front-end. Can I trouble you later for the implementation of the placeholder for the albums in that case? :) |
Yes of course, would be happy to help. You can ping me here, and I should get to it. Get well soon! |
…, because imagick cant compress webp properly
e04863b
to
52fd83e
Compare
@aSouchereau I rebased your branch on top of v6 (future) so that it will be easier to merge, all the Livewire thing is gone. I also updated PhotoResource / SizeVariantsResource to provide the required data. I think there is still It could also be interesting to integrate with the Maintenance page. See:
:) For the filter, I guess https://tailwindcss.com/docs/blur will do the job, most likely |
Sounds good, I agree with adding the maintenance page button. I will have some extra free time in the next week to get started |
Implements backend for #2258
Adds low quality image placeholder to be displayed while album covers are downloading.
Improves perceived loading times.
Approach:
Notes for implementing the frontend
filter: blur();
orbackdrop-filter: blur();
. I've found that between 8-15px looks best.