Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Feature: Low Quality Image Placeholder #2558

Open
wants to merge 40 commits into
base: v6
Choose a base branch
from
Open

New Feature: Low Quality Image Placeholder #2558

wants to merge 40 commits into from

Commits on Oct 19, 2024

  1. Add placeholder size variant

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3d4c390 View commit details
    Browse the repository at this point in the history

  2. Add localization for placeholder variant

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4befd9a View commit details
    Browse the repository at this point in the history

  3. Add placeholder to size variants array

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c7f762e View commit details
    Browse the repository at this point in the history

  4. Include placeholder in generate thumbs command

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    7128a04 View commit details
    Browse the repository at this point in the history

  5. Add config option for enabling placeholders

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    062bfc0 View commit details
    Browse the repository at this point in the history

  6. Update tests for placeholder size variant

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f5e6912 View commit details
    Browse the repository at this point in the history

  7. Update variant naming strategy so all placeholders use webp extension

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    922e0df View commit details
    Browse the repository at this point in the history

  8. Temporary: add compression quality override

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4c62c08 View commit details
    Browse the repository at this point in the history

  9. Add method to convert image files using GD

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1229c8d View commit details
    Browse the repository at this point in the history

  10. Add workaround to call GdHandler convert function from imagickHandler… 

    …, because imagick cant compress webp properly
    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    21439dd View commit details
    Browse the repository at this point in the history

  11. Remove new, nonfunctional imagick convert method

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    088bc3d View commit details
    Browse the repository at this point in the history

  12. Add placeholder encoding pipe

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2d10c00 View commit details
    Browse the repository at this point in the history

  13. Update url attribute to handle placeholders

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e71cf7c View commit details
    Browse the repository at this point in the history

  14. Update thumb dto to include placeholder

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5f398a7 View commit details
    Browse the repository at this point in the history

  15. Fix attempting to get symLinkURL for nonexistent placeholder file

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2a3ef50 View commit details
    Browse the repository at this point in the history

  16. Fix attempting to get file when placeholder is null

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e4e2b16 View commit details
    Browse the repository at this point in the history

  17. Use correct BaseConfigMigration class

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    de0cfa3 View commit details
    Browse the repository at this point in the history

  18. Remove call to undefined method

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    51f9c28 View commit details
    Browse the repository at this point in the history

  19. Add pipe to other set of standalone pipes

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    8e81f4f View commit details
    Browse the repository at this point in the history

  20. Add placeholder encoding to generate thumbs command

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c4f2c90 View commit details
    Browse the repository at this point in the history

  21. Refactor encoding logic to separate class

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fdea538 View commit details
    Browse the repository at this point in the history

  22. Fix call on possibly null object

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9b4e6d6 View commit details
    Browse the repository at this point in the history

  23. Add test to check if placeholder is encoded from upload

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    53ae8f8 View commit details
    Browse the repository at this point in the history

  24. Separate compression step into its own function

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ee6acd5 View commit details
    Browse the repository at this point in the history

  25. Undo add convertAndSave GdHandler function

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    a818b38 View commit details
    Browse the repository at this point in the history

  26. Add placeholder diagnostics check

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c2b5a68 View commit details
    Browse the repository at this point in the history

  27. Remove old placeholder quality definition

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ade2680 View commit details
    Browse the repository at this point in the history

  28. Remove accidental whitespace

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4b1824d View commit details
    Browse the repository at this point in the history

  29. Ignore phpstan on lines using dynamic property names

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    42572cb View commit details
    Browse the repository at this point in the history

  30. Add gif upload failure workaround

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    51063d0 View commit details
    Browse the repository at this point in the history

  31. Add command to encode placeholders

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3826a15 View commit details
    Browse the repository at this point in the history

  32. Refactor placeholder encoder

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    7215905 View commit details
    Browse the repository at this point in the history

  33. Remove encoding from generate thumbs

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    be6f2d9 View commit details
    Browse the repository at this point in the history

  34. Update encoding tests

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    80151e6 View commit details
    Browse the repository at this point in the history

  35. Add placeholder to list of ignored private property errors

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c1ef199 View commit details
    Browse the repository at this point in the history

  36. Fix command returning wrong exit code

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    d6ddab9 View commit details
    Browse the repository at this point in the history

  37. Add encoding step to legacy code path

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    618a099 View commit details
    Browse the repository at this point in the history

  38. fix gif issue, remove workaround

    @aSouchereau @ildyria
    aSouchereau authored and ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fae77b8 View commit details
    Browse the repository at this point in the history

  39. formatting

    @ildyria
    ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    de5eaab View commit details
    Browse the repository at this point in the history

  40. fix missing data in legacy resource

    @ildyria
    ildyria committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    52fd83e View commit details
    Browse the repository at this point in the history