Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups #50

Merged
merged 51 commits into from
Sep 6, 2023
Merged

Cleanups #50

merged 51 commits into from
Sep 6, 2023

Conversation

podborski
Copy link
Member

@podborski podborski commented Aug 30, 2023

  • Initial clean ups for user-defined features which are now redundant as those can be found using the presence of the 4CCs which we already parse.
  • add new issue template, improve existing templates (cherry picked, merged)
  • make unrecognized features fail the pipeline
  • fix all user-defined features in all files
  • add missing boxes

@podborski
Copy link
Member Author

@DenizUgur could you take a look how to resolve the failing test. I moved out sample entries defined in ISOBMFF to codecs.json in this commit 5ef2d49, and it seems to not like it.

@DenizUgur
Copy link
Collaborator

DenizUgur commented Sep 1, 2023

This happened because in that commit you removed the only entry that listed its type as SampleEntry. I'll have to check if this error can be silenced. There is another hierarchical check for these kind of indirect type matches. Maybe this was a corner case.

{
    "fourcc": "encs",
    "description": "Encrypted Systems stream",
-   "type": "SampleEntry",
    "containers": ["stsd"],
    "syntax": "TODO: Bug. see 'rest'"
}

> Check if type has inheritors, if so it may be abstract class
> Convert warning to error
.gitignore Outdated Show resolved Hide resolved
data/standard_features/14496-15/codecs.json Show resolved Hide resolved
data/standard_features/14496-15/codecs.json Show resolved Hide resolved
@podborski podborski merged commit 53f1e3d into main Sep 6, 2023
5 checks passed
@podborski podborski deleted the cleanups branch September 6, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants