-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4.y] Test VERIFY_PEER / VERIFY_NONE work against real cluster #545
Conversation
ef89b7f
to
e12b5a3
Compare
Ooh, exciting! Yes, it can run in CI. (IIUC service containers can't be --priviledged, but directly executing
|
71a5ab8
to
ca920f1
Compare
79a20c1
to
f4c1a48
Compare
Followup to ManageIQ#540, tests that it really fixes ManageIQ#525. That bug only existed on master, not v4.y branch, but testing the behavior on both is good.
a40c256
to
cafebe0
Compare
Yay, `docker run --priviledged` is allowed! k0s starts up really fast too. (only on linux, keeping regular `rake test` on macos because no `docker`.)
Sometimes minitest starts and then just hangs printing ...nothing? Run options: --seed 34017 # Running: Error: The operation was canceled. Github's default job timeout is a generous 6 hours! https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits But waiting is not productive and wasteful (and will burn our free minutes). Setting outer job timeout longer for `bundle install`. Hoping an inner SIGTERM received from while job is still running may allow the test to print some traceback. I have no idea where it's getting stuck. (macos has no `timeout` command, but most or all stuck runs were linux.) (I would suspect `exercise_watcher_with_timeout` but also saw same symptoms on another PR without k0s tests)
cafebe0
to
367d432
Compare
OK pin-pointed the timeout:
Probably |
@russell @grosser @agrare I still need to tackle the runaway test ^ but please review the general direction. I want real end-to-end tests of when TLS verification actually verifies, and the setup here of starting a real cluster works surprisingly fast and opens the door to many more future real-cluster tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ nice approach
Co-authored-by: Michael Grosser <michael@grosser.it>
shows stacktrace within Rake itself, not within test.
Ignoring truffleruby, which always fails anyway (opened #551). Same CI situation adding these on master branch (#550). But these provide real value so I'm going to merge and we'll see how flaky it is in future... (Worst-case, can always fall back to not running real-cluster tests in CI.) |
Followup to #540. (It fixed #525 which was only broken on master, not v4.y, but good to have these tests here too.)
Adding tests that
Client
honor VERIFY_PEER/VERIFY_NONE by connecting to the temporary cluster during test/config/update_certs_k0s.rb script.They are skipped during a regular
rake test
so they will NOT run in CI.(Can we run docker --priviledged in github actions?)