Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test VERIFY_PEER / VERIFY_NONE work against real cluster #550

Merged
merged 15 commits into from
Mar 14, 2022

Conversation

cben
Copy link
Collaborator

@cben cben commented Mar 14, 2022

Same as #545 but merged into master branch.

cben and others added 15 commits February 22, 2022 10:33
[v4.y] Regenerate test TLS certs, stop skipping those tests
VCR was interfering with my attempts to connect to a real cluster,
despite `WebMock.enable_net_connect!`.
What's worse, it depended on order that tests executed.

[This won't be needed on master, we dropped the VCR test in ManageIQ#495.]
[v4.y] Ensure VCR doesn't leak into other tests
Followup to ManageIQ#540,
tests that it really fixes ManageIQ#525.

That bug only existed on master, not v4.y branch, but testing the behavior on both is good.
Yay, `docker run --priviledged` is allowed!  k0s starts up really fast too.
(only on linux, keeping regular `rake test` on macos because no `docker`.)
Sometimes minitest starts and then just hangs printing ...nothing?

    Run options: --seed 34017

    # Running:

    Error: The operation was canceled.

Github's default job timeout is a generous 6 hours!
https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits
But waiting is not productive and wasteful (and will burn our free minutes).

Setting outer job timeout longer for `bundle install`.
Hoping an inner SIGTERM received from while job is still running may allow
the test to print some traceback.  I have no idea where it's getting stuck.
(macos has no `timeout` command, but most or all stuck runs were linux.)

(I would suspect `exercise_watcher_with_timeout` but also saw same
symptoms on another PR without k0s tests)
Co-authored-by: Michael Grosser <michael@grosser.it>
shows stacktrace within Rake itself, not within test.
@cben
Copy link
Collaborator Author

cben commented Mar 14, 2022

As explained in #545 these are somewhat flaky (may get stuck, added 3min & 10min timeouts) but provide value, merging.

@cben cben merged commit 6897f25 into ManageIQ:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant