-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test VERIFY_PEER / VERIFY_NONE work against real cluster #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[v4.y] Regenerate test TLS certs, stop skipping those tests
VCR was interfering with my attempts to connect to a real cluster, despite `WebMock.enable_net_connect!`. What's worse, it depended on order that tests executed. [This won't be needed on master, we dropped the VCR test in ManageIQ#495.]
[v4.y] Ensure VCR doesn't leak into other tests
[v4.y] Test on Ruby 3.1
Followup to ManageIQ#540, tests that it really fixes ManageIQ#525. That bug only existed on master, not v4.y branch, but testing the behavior on both is good.
Yay, `docker run --priviledged` is allowed! k0s starts up really fast too. (only on linux, keeping regular `rake test` on macos because no `docker`.)
Sometimes minitest starts and then just hangs printing ...nothing? Run options: --seed 34017 # Running: Error: The operation was canceled. Github's default job timeout is a generous 6 hours! https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits But waiting is not productive and wasteful (and will burn our free minutes). Setting outer job timeout longer for `bundle install`. Hoping an inner SIGTERM received from while job is still running may allow the test to print some traceback. I have no idea where it's getting stuck. (macos has no `timeout` command, but most or all stuck runs were linux.) (I would suspect `exercise_watcher_with_timeout` but also saw same symptoms on another PR without k0s tests)
Co-authored-by: Michael Grosser <michael@grosser.it>
shows stacktrace within Rake itself, not within test.
cben
force-pushed
the
test_real_cluster_ssl_verify
branch
from
March 14, 2022 10:09
c4a4fb2
to
1dfaa6e
Compare
As explained in #545 these are somewhat flaky (may get stuck, added 3min & 10min timeouts) but provide value, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #545 but merged into master branch.