Fix migrations being run from a plugin #22626
Conversation
Before this commit, when running bin/setup on a fresh checkout of ui-classic, the migrate_database step would fail because it would run in the spec/manageiq directory as opposed to the plugin root directory. What happens is that the spec/manageiq directory doesn't have a Gemfile.lock, because the bundle install happens in the plugin root, and so when migrate_database runs db:migrate from the spec/manageiq directory it fails saying it can't find certain gems. This commit changes it to run db:migrate from the plugin root directory. Additionally, I've added a create_database step, which is a noop when the database exists, but also simplifies brand new checkout runs.
| @@ -24,8 +24,10 @@ def self.manageiq_plugin_update(plugin_root = nil, force_bundle_update: true) | |||
| ensure_config_files | |||
|
|
|||
| unless ENV["CI"] | |||
There was a problem hiding this comment.
On a separate topic, we have defined a separate ENV var for this step in the core bin/setup, but I don't think it's available in the plugin's bin/setup.
Line 17 in b6aef66
I'm going to do this in a followup, but it might be preferable to default that same variable in the methods above, and that would allow the caller to do something like SKIP_DATABASE_SETUP=false in a CI env if they want to have the development database setup anyway (for example in a cypress test suite)
|
Some comments on commit Fryguy@be9c3e6 lib/manageiq/environment.rb
|
|
Checked commit Fryguy@be9c3e6 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint lib/manageiq/environment.rb
|
Before this commit, when running bin/setup on a fresh checkout of
ui-classic, the migrate_database step would fail because it would run in
the spec/manageiq directory as opposed to the plugin root directory.
What happens is that the spec/manageiq directory doesn't have a
Gemfile.lock, because the bundle install happens in the plugin root, and
so when migrate_database runs db:migrate from the spec/manageiq
directory it fails saying it can't find certain gems.
This commit changes it to run db:migrate from the plugin root directory.
Additionally, I've added a create_database step, which is a noop when
the database exists, but also simplifies brand new checkout runs.
@agrare Please review.