Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ape token mainnet #27974

Merged
merged 3 commits into from
Oct 22, 2024
Merged

feat: add ape token mainnet #27974

merged 3 commits into from
Oct 22, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 19, 2024

Description

PR to add Ape token icon and display ape icon for mainnet

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2024-10-19 at 23 01 54

After

Screen.Recording.2024-10-19.at.22.55.31.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner October 19, 2024 20:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2bd8eab]
Page Load Metrics (1904 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34426091822395190
domContentLoaded16732547186420196
load168626111904213102
domInteractive27246574722
backgroundConnect10103352512
firstReactRender45197983115
getState495232613
initialActions00000
loadScripts11361951136717584
setupStore1172312311
uiStartup188027902114252121
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 152 Bytes (0.00%)

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Oct 21, 2024
@gambinish
Copy link
Contributor

Should we add this on mobile too? I can do this today

@sahar-fehri
Copy link
Contributor Author

Should we add this on mobile too? I can do this today

They did not mention it, but i think it would good to have mobile display the right network icon too! Thnx 🙏

@metamaskbot
Copy link
Collaborator

Builds ready [29f8751]
Page Load Metrics (1861 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45527211785374180
domContentLoaded16062532181618287
load161728551861246118
domInteractive20139552512
backgroundConnect10328487134
firstReactRender45180873517
getState5113182713
initialActions01000
loadScripts11411897134214670
setupStore10115413115
uiStartup180937272113392188
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 152 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [b7a172a]
Page Load Metrics (2118 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33423482032411197
domContentLoaded17932287208512359
load18052351211812761
domInteractive18261665828
backgroundConnect982362311
firstReactRender602941255828
getState56122209
initialActions01000
loadScripts12751756152210651
setupStore137127209
uiStartup20202958237620699
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 152 Bytes (0.00%)

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit b87b4e5 Oct 22, 2024
76 checks passed
@sahar-fehri sahar-fehri deleted the feat/add-ape-icon-chainId branch October 22, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants