Rename passwordFile to hashedPasswordFile #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the rename that was done in nixpkgs. Reference PR NixOS/nixpkgs#254080
Mic92
reviewed
Nov 5, 2023
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| users.users.example-user = { | |||
| isNormalUser = true; | |||
| passwordFile = config.sops.secrets.test_key.path; | |||
| hashedPasswordFile = config.sops.secrets.test_key.path; | |||
There was a problem hiding this comment.
For the 22.03 test we need to make this conditional.
There was a problem hiding this comment.
Ah yes, of course. I've added a fixup b43feda.
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0a9d5e4 |
|
@Mic92 , not sure if you noticed or even if you care about this, but commits did not get squashed before being merged, so now there are two commits on the master branch when there should only be one fixup-ed commit. |
|
Missed it. I can probably use mergify next time to squash it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the rename that was done in nixpkgs.
Reference PR NixOS/nixpkgs#254080