Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename passwordFile to hashedPasswordFile #433

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Rename passwordFile to hashedPasswordFile #433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4196eb9
Rename passwordFile to hashedPasswordFile
Pizmovc Nov 3, 2023
b43feda
fixup! Rename passwordFile to hashedPasswordFile
Pizmovc Nov 5, 2023
90b0040
Merge branch 'master' into master
mergify[bot] Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ lrwxrwxrwx 1 root root 40 Jul 19 22:36 /var/lib/hass/secrets.yaml -> /run/secret
## Setting a user's password

sops-nix has to run after NixOS creates users (in order to specify what users own a secret.)
This means that it's not possible to set `users.users.<name>.passwordFile` to any secrets managed by sops-nix.
This means that it's not possible to set `users.users.<name>.hashedPasswordFile` to any secrets managed by sops-nix.
To work around this issue, it's possible to set `neededForUsers = true` in a secret.
This will cause the secret to be decrypted to `/run/secrets-for-users` instead of `/run/secrets` before NixOS creates users.
As users are not created yet, it's not possible to set an owner for these secrets.
Expand All @@ -580,7 +580,7 @@ As users are not created yet, it's not possible to set an owner for these secret

users.users.mic92 = {
isNormalUser = true;
passwordFile = config.sops.secrets.my-password.path;
hashedPasswordFile = config.sops.secrets.my-password.path;
};
}
```
Expand Down
2 changes: 1 addition & 1 deletion pkgs/sops-install-secrets/nixos-test.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

users.users.example-user = {
isNormalUser = true;
passwordFile = config.sops.secrets.test_key.path;
hashedPasswordFile = config.sops.secrets.test_key.path;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the 22.03 test we need to make this conditional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, of course. I've added a fixup b43feda.

};
};

Expand Down