CUDA_MODULE_LOADING: use default lazy loading #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer to set fewer magic variables. Eager loading cuDNN/cuBLAS during XLA compilation can also be noticably slow.
|
Does it affect only compilation time? How much do we save on that? |
|
Opened #842 with a straight revert. |
olupton
added a commit
that referenced
this pull request
Jun 13, 2024
#842) Prefer to set fewer magic variables. Note that these values were anyway not used inside e.g. the JAX unit test environment, so this was a source of inconsistency. Eager loading cuDNN/cuBLAS during XLA compilation can also be noticeably slow. See documentation here: https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#cuda-environment-variables Replaces #831. Reverts #329. Co-authored-by: ashors1 <ashors@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer to set fewer magic variables. Eager loading cuDNN/cuBLAS during XLA compilation can also be noticably slow.
This was added in #329