Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adds CUDA_MODULE_LOADING=EAGER to core jax container env vars" #842

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented May 21, 2024

Prefer to set fewer magic variables.
Note that these values were anyway not used inside e.g. the JAX unit test environment, so this was a source of inconsistency.
Eager loading cuDNN/cuBLAS during XLA compilation can also be noticeably slow.
See documentation here: https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#cuda-environment-variables
Replaces #831. Reverts #329.

@olupton olupton requested a review from ashors1 May 27, 2024 10:52
Copy link
Contributor

@ashors1 ashors1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the CI because the previous run timed out. But assuming the CI passes, LGTM

@olupton olupton merged commit ec14452 into main Jun 13, 2024
151 of 164 checks passed
@olupton olupton deleted the revert-329-rosetta-env-vars branch June 13, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants