bump te to 1.10 #253
Open
bump te to 1.10 #253
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
requested review from
dorotat-nv,
jomitchellnv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
|
/build-ci |
jstjohn
reviewed
Oct 3, 2024
Dockerfile
Outdated
| NVTE_FRAMEWORK=pytorch NVTE_WITH_USERBUFFERS=1 MPI_HOME=/usr/local/mpi pip install . | ||
| RUN NVTE_FRAMEWORK=pytorch NVTE_WITH_USERBUFFERS=1 MPI_HOME=/usr/local/mpi \ | ||
| pip install -v --no-build-isolation --no-cache-dir \ | ||
| git+https://github.com/NVIDIA/TransformerEngine.git@v1.10 |
There was a problem hiding this comment.
IMO I would prefer having this as an ARG for readability, Something like ARG TE_VERSION_TAG=v1.10 and then modifying the line that uses it: git+https://github.com/NVIDIA/TransformerEngine.git@${TE_VERSION_TAG}?
jstjohn
approved these changes
Oct 3, 2024
farhadrgh
approved these changes
Oct 4, 2024
malcolmgreaves
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps transformer engine to 1.10