Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add save_every_n_steps to esm2 pretraining #316

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add save_every_n_steps to esm2 pretraining #316

wants to merge 3 commits into from
+8 −1

Conversation

sichu2023
Copy link
Collaborator

No description provided.

pstjohn
pstjohn approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@pstjohn pstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we automatically delete old checkpoints? Is there a "keep best" option? Just wondering how that works if we don't run validation before saving

@sichu2023
Copy link
Collaborator Author

Do we automatically delete old checkpoints? Is there a "keep best" option? Just wondering how that works if we don't run validation before saving

There is a save top k option.
https://github.com/NVIDIA/bionemo-framework/blob/sichu/add_save_every_n_steps/scripts/protein/esm2/esm2_pretrain.py#L246

@sichu2023
Copy link
Collaborator Author

/build-ci

@sichu2023 sichu2023 closed this Oct 16, 2024
@sichu2023 sichu2023 reopened this Oct 16, 2024
@sichu2023
Copy link
Collaborator Author

/build-ci

@sichu2023
Copy link
Collaborator Author

/build-ci

@malcolmgreaves
Copy link
Collaborator

@sichu2023 is this in/not in 24.10 release? I labeled as not in, but perhaps this counts as a bugfix?

@sichu2023
Copy link
Collaborator Author

@sichu2023 is this in/not in 24.10 release? I labeled as not in, but perhaps this counts as a bugfix?

Not in. Will call it an added feature.

@sichu2023 sichu2023 enabled auto-merge (squash) October 16, 2024 17:07
@sichu2023 sichu2023 added the enhancement New feature or request label Oct 16, 2024
@sichu2023
Copy link
Collaborator Author

/build-ci

@sichu2023
Copy link
Collaborator Author

/build-ci

@sichu2023
Copy link
Collaborator Author

/build-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmgreaves malcolmgreaves malcolmgreaves approved these changes

@pstjohn pstjohn pstjohn approved these changes

@jomitchellnv jomitchellnv Awaiting requested review from jomitchellnv

@jstjohn jstjohn Awaiting requested review from jstjohn jstjohn is a code owner

@skothenhill-nv skothenhill-nv Awaiting requested review from skothenhill-nv skothenhill-nv is a code owner

Assignees

@sichu2023 sichu2023

Labels
enhancement New feature or request NOT_related_to_v24.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sichu2023 @malcolmgreaves @pstjohn