Match resumption loss curve #362
Open
+130
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichu2023
requested review from
jstjohn,
malcolmgreaves,
skothenhill-nv,
farhadrgh,
dorotat-nv and
pstjohn
as code owners
|
/build-ci |
farhadrgh
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
sub-packages/bionemo-geneformer/src/bionemo/geneformer/data/singlecell/datamodule.py
Outdated
Show resolved
Hide resolved
jstjohn
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
sub-packages/bionemo-geneformer/src/bionemo/geneformer/data/singlecell/datamodule.py
Outdated
Show resolved
Hide resolved
jstjohn
reviewed
Oct 25, 2024
pstjohn
reviewed
Oct 25, 2024
jstjohn
reviewed
Oct 25, 2024
pstjohn
reviewed
Oct 25, 2024
pstjohn
approved these changes
Oct 25, 2024
sichu2023
force-pushed
the
sichu/match-resumption-loss-curve
branch
from
fadca1e
to
44a9b39
Compare
sichu2023
commented
Oct 25, 2024
…new dataloaders are requested as a side effect currently
sichu2023
force-pushed
the
sichu/match-resumption-loss-curve
branch
from
636a849
to
09a2efa
Compare
sichu2023
force-pushed
the
sichu/match-resumption-loss-curve
branch
from
09a2efa
to
714b6ef
Compare
|
/build-ci |
jstjohn
reviewed
Oct 25, 2024
| @@ -183,6 +183,7 @@ def main( | |||
| strategy=strategy, | |||
| limit_val_batches=limit_val_batches, # This controls upsampling and downsampling | |||
| val_check_interval=val_check_interval, | |||
| log_every_n_steps=log_every_n_steps, | |||
There was a problem hiding this comment.
You need to add this in one other spot to get logging to be less frequent, in your nl.MegatronStrategy above add
progress_interval=log_every_n_steps,
jstjohn
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add additional resumption mechanism to datamodule to ensure stop-and-go and continuous pretraining has the same training loss curve.
Details
Still has a small discrepancy right at resumption but does not affect subsequent training/validation curve.
WANDB log
Testing
To be implemented in subsequent PR on stop-and-go test refactoring.