gnome-pomodoro 0.24.1 -> 0.26.0 #345165
Merged
gnome-pomodoro 0.24.1 -> 0.26.0 #345165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
Just found out that I'm maintaining three pomodoro packages 😅 please also consider add yourself to maintainers |
Sure, I've added a commit making myself a maintainer on this package. Thanks for your review! |
This commit adds myself as a maintainer to the gnome-pomodoro package in addition to adding myself to the overall list.
Compile schemas manually to follow Nix conventions. The gnome.post_install(glib_compile_schemas: true) param tries to compile schemas in `<prefix>/<datadir>/glib-2.0/schemas`, which is not compatible with the Nix way of handling gsettings schemas. This commit patches that option out and manually adds a compilation step to the preFixup hook, which fixes the issue and results in a fully working local install of the program.
Aleksanaa
force-pushed
the
gnome-pomodoro-update
branch
from
80ee93f
to
76fa465
Compare
Aleksanaa
changed the title
h7x4
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR brings gnome-pomodoro up to the latest published version which is compatible with both Gnome 46 and 47. Both the application portion and the extension are functional.
The fix-schema-path.patch had to be changed, as the way that schemas were compiled upstream changed after v0.24 which broke the existing build steps. I also added a preFixup patch to compile these schemas manually.
Fixes #314999.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.