Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-pomodoro 0.24.1 -> 0.26.0 #345165

Merged
merged 3 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions maintainers/maintainer-list.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8454,6 +8454,11 @@
githubId = 15121114;
name = "Tom Herbers";
};
herschenglime = {
github = "Herschenglime";
githubId = 69494718;
name = "Herschenglime";
};
hexa = {
email = "hexa@darmstadt.ccc.de";
matrix = "@hexa:lossy.network";
Expand Down
35 changes: 9 additions & 26 deletions pkgs/by-name/gn/gnome-pomodoro/fix-schema-path.patch
Original file line number Diff line number Diff line change
@@ -1,29 +1,3 @@
diff --git a/data/meson.build b/data/meson.build
index 5e4ce69..982b3c9 100644
--- a/data/meson.build
+++ b/data/meson.build
@@ -31,7 +31,7 @@ i18n.merge_file(

install_data(
'org.gnome.pomodoro.gschema.xml',
- install_dir: get_option('datadir') / 'glib-2.0' / 'schemas',
+ install_dir: gschema_dir,
)

subdir('icons')
diff --git a/meson-post-install.sh b/meson-post-install.sh
index bf4013a..c87fba4 100644
--- a/meson-post-install.sh
+++ b/meson-post-install.sh
@@ -7,7 +7,7 @@ datadir="${prefix}/$1"
# want/need us to do the below
if [ -z "${DESTDIR}" ]; then
echo "Compiling GSchema..."
- glib-compile-schemas "${datadir}/glib-2.0/schemas"
+ glib-compile-schemas "${datadir}/gsettings-schemas/@pname@-@version@/glib-2.0/schemas"

echo "Updating icon cache..."
gtk-update-icon-cache -f -t "${datadir}/icons/hicolor"
diff --git a/meson.build b/meson.build
index 09857a1..a07d27c 100644
--- a/meson.build
Expand All @@ -38,3 +12,12 @@ index 09857a1..a07d27c 100644
plugin_libdir = get_option('prefix') / get_option('libdir') / meson.project_name() / 'plugins'
extension_dir = get_option('prefix') / get_option('datadir') / 'gnome-shell' / 'extensions' / 'pomodoro@arun.codito.in'

@@ -134,7 +135,7 @@
subdir('tests')

gnome.post_install(
- glib_compile_schemas: true,
+ glib_compile_schemas: false,
gtk_update_icon_cache: true,
update_desktop_database: true,
)
62 changes: 36 additions & 26 deletions pkgs/by-name/gn/gnome-pomodoro/package.nix
Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@
{ lib
, stdenv
, fetchFromGitHub
, substituteAll
, meson
, ninja
, pkg-config
, wrapGAppsHook3
, desktop-file-utils
, libcanberra
, gst_all_1
, vala
, gtk3
, gom
, sqlite
, libxml2
, glib
, gobject-introspection
, json-glib
, libpeas
, gsettings-desktop-schemas
, gettext
{
lib,
stdenv,
fetchFromGitHub,
substituteAll,
meson,
ninja,
pkg-config,
wrapGAppsHook3,
desktop-file-utils,
libcanberra,
gst_all_1,
vala,
gtk3,
gom,
sqlite,
libxml2,
glib,
gobject-introspection,
json-glib,
libpeas,
gsettings-desktop-schemas,
gettext,
}:

stdenv.mkDerivation rec {
pname = "gnome-pomodoro";
version = "0.24.1";
version = "0.26.0";

src = fetchFromGitHub {
owner = pname;
repo = pname;
rev = version;
hash = "sha256-Ml3znMz1Q9593rMgfAST8k9QglxMG9ocFD7W8kaFWCw=";
hash = "sha256-icyS/K6H90/DWYvqJ7f7XXTTuIwLea3k+vDDEBYil6o=";
};

patches = [
Expand All @@ -42,6 +42,13 @@ stdenv.mkDerivation rec {
})
];

# Manually compile schemas for package since meson option
# gnome.post_install(glib_compile_schemas) used by package tries to compile in
# the wrong dir.
preFixup = ''
glib-compile-schemas ${glib.makeSchemaPath "$out" "${pname}-${version}"}
'';

nativeBuildInputs = [
meson
ninja
Expand Down Expand Up @@ -76,7 +83,10 @@ stdenv.mkDerivation rec {
This GNOME utility helps to manage time according to Pomodoro Technique.
It intends to improve productivity and focus by taking short breaks.
'';
maintainers = with maintainers; [ aleksana ];
maintainers = with maintainers; [
aleksana
herschenglime
];
license = licenses.gpl3Plus;
platforms = platforms.linux;
};
Expand Down