-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtualbox: 7.0.20 -> 7.0.22 #350707
virtualbox: 7.0.20 -> 7.0.22 #350707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the changes. Can't test it right now though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the second commit
@blitz Could you please create a PR once, you have released a (official) virtualboxKVM patch for the 7.0.22 version |
7b28444
to
b78ee7e
Compare
As you wish but this need to be backported to stable so I would have preferred to not a break a package. |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-350707-to-release-24.05 origin/release-24.05
cd .worktree/backport-350707-to-release-24.05
git switch --create backport-350707-to-release-24.05
git cherry-pick -x 299522b78a546b0238861cdad93f340f0b62b8fd |
Fixes CVE-2024-21248, CVE-2024-21253, CVE-2024-21259, CVE-2024-21263 and CVE-2024-21273. Changelog: https://www.virtualbox.org/wiki/Changelog-7.0#v22 (cherry picked from commit 299522b)
Is virtualboxKvm an unimportant package that we're OK with breaking? Because this PR breaks it, and now I wonder whether the backport to stable should wait until virtualboxKvm is fixed, or not? |
Fixes CVE-2024-21248, CVE-2024-21253, CVE-2024-21259, CVE-2024-21263 and CVE-2024-21273.
Changelog:
https://www.virtualbox.org/wiki/Changelog-7.0#v22
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixpkgs-review
resultGenerated using
nixpkgs-review
.Command:
nixpkgs-review pr 350707
x86_64-linux
⏩ 2 packages marked as broken and skipped:
❌ 7 packages failed to build:
✅ 37 packages built:
Add a 👍 reaction to pull requests you find important.