Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.05] virtualbox: 7.0.18 -> 7.0.22 #351261

Open
wants to merge 3 commits into
base: release-24.05
Choose a base branch
from
Open

[24.05] virtualbox: 7.0.18 -> 7.0.22 #351261

wants to merge 3 commits into from

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Oct 25, 2024 •
edited
Loading

Cherry-picks of #350707, #338117 and #330796

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LeSuisse LeSuisse marked this pull request as ready for review October 25, 2024 19:58
@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 351261 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4_hardened.virtualbox
  • linuxKernel.packages.linux_5_4_hardened.virtualboxGuestAdditions
  • linuxPackages_5_4_hardened.virtualbox
  • linuxPackages_5_4_hardened.virtualboxGuestAdditions
7 packages failed to build:
  • linuxPackages_5_15_hardened.virtualbox (linuxKernel.packages.linux_5_15_hardened.virtualbox)
  • linuxPackages_5_15_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_15_hardened.virtualboxGuestAdditions)
  • linuxPackages_6_1_hardened.virtualbox (linuxKernel.packages.linux_6_1_hardened.virtualbox)
  • linuxPackages_6_1_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_6_1_hardened.virtualboxGuestAdditions)
  • linuxPackages_hardened.virtualbox (linuxPackages_6_6_hardened.virtualbox)
  • linuxPackages_hardened.virtualboxGuestAdditions (linuxPackages_6_6_hardened.virtualboxGuestAdditions)
  • virtualboxKvm
41 packages built:
  • linuxKernel.packages.linux_4_19.virtualbox
  • linuxKernel.packages.linux_4_19.virtualboxGuestAdditions
  • linuxPackages_4_19_hardened.virtualbox (linuxKernel.packages.linux_4_19_hardened.virtualbox)
  • linuxPackages_4_19_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_4_19_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_5_10.virtualbox
  • linuxKernel.packages.linux_5_10.virtualboxGuestAdditions
  • linuxPackages_5_10_hardened.virtualbox (linuxKernel.packages.linux_5_10_hardened.virtualbox)
  • linuxPackages_5_10_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_10_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_5_15.virtualbox
  • linuxKernel.packages.linux_5_15.virtualboxGuestAdditions
  • linuxKernel.packages.linux_5_4.virtualbox
  • linuxKernel.packages.linux_5_4.virtualboxGuestAdditions
  • linuxKernel.packages.linux_6_1.virtualbox
  • linuxKernel.packages.linux_6_1.virtualboxGuestAdditions
  • linuxKernel.packages.linux_6_10.virtualbox
  • linuxKernel.packages.linux_6_10.virtualboxGuestAdditions
  • linuxPackages_latest.virtualbox (linuxKernel.packages.linux_6_11.virtualbox)
  • linuxPackages_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_6_11.virtualboxGuestAdditions)
  • linuxPackages.virtualbox (linuxKernel.packages.linux_6_6.virtualbox)
  • linuxPackages.virtualboxGuestAdditions (linuxKernel.packages.linux_6_6.virtualboxGuestAdditions)
  • linuxPackages_latest-libre.virtualbox (linuxKernel.packages.linux_latest_libre.virtualbox)
  • linuxPackages_latest-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_latest_libre.virtualboxGuestAdditions)
  • linuxPackages-libre.virtualbox (linuxKernel.packages.linux_libre.virtualbox)
  • linuxPackages-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_libre.virtualboxGuestAdditions)
  • linuxPackages_lqx.virtualbox (linuxKernel.packages.linux_lqx.virtualbox)
  • linuxPackages_lqx.virtualboxGuestAdditions (linuxKernel.packages.linux_lqx.virtualboxGuestAdditions)
  • linuxPackages_xanmod.virtualbox (linuxKernel.packages.linux_xanmod.virtualbox)
  • linuxPackages_xanmod.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod.virtualboxGuestAdditions)
  • linuxPackages_xanmod_latest.virtualbox (linuxKernel.packages.linux_xanmod_latest.virtualbox ,linuxPackages_xanmod_stable.virtualbox)
  • linuxPackages_xanmod_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod_latest.virtualboxGuestAdditions ,linuxPackages_xanmod_stable.virtualboxGuestAdditions)
  • linuxPackages_zen.virtualbox (linuxKernel.packages.linux_zen.virtualbox)
  • linuxPackages_zen.virtualboxGuestAdditions (linuxKernel.packages.linux_zen.virtualboxGuestAdditions)
  • virtualbox
  • virtualbox.modsrc
  • virtualboxExtpack
  • virtualboxHardened
  • virtualboxHardened.modsrc
  • virtualboxHeadless
  • virtualboxHeadless.modsrc
  • virtualboxWithExtpack
  • virtualboxWithExtpack.modsrc

@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 351261 run on x86_64-linux 1
4 packages marked as broken and skipped:

7 packages failed to build:

* linuxPackages_5_15_hardened.virtualbox (linuxKernel.packages.linux_5_15_hardened.virtualbox)

* linuxPackages_5_15_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_15_hardened.virtualboxGuestAdditions)

* linuxPackages_6_1_hardened.virtualbox (linuxKernel.packages.linux_6_1_hardened.virtualbox)

* linuxPackages_6_1_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_6_1_hardened.virtualboxGuestAdditions)

* linuxPackages_hardened.virtualbox (linuxPackages_6_6_hardened.virtualbox)

* linuxPackages_hardened.virtualboxGuestAdditions (linuxPackages_6_6_hardened.virtualboxGuestAdditions)

The above are already broken.

* virtualboxKvm

Regression!

$ nix-build -A virtualboxKvm

these 2 derivations will be built:
  /nix/store/rzgjh2hfqw3w1i2xlfbq77mbizlhzdji-virtualbox-7.0.22-kvm-dev-20240828.patch.drv
  /nix/store/3330f3ccsy63pphadn40g3f2djdawblg-virtualbox-7.0.22.drv
building '/nix/store/rzgjh2hfqw3w1i2xlfbq77mbizlhzdji-virtualbox-7.0.22-kvm-dev-20240828.patch.drv'...

trying https://github.com/cyberus-technology/virtualbox-kvm/releases/download/dev-20240828/kvm-backend-7.0.22-dev-20240828.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     9    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 404
error: cannot download virtualbox-7.0.22-kvm-dev-20240828.patch from any mirror
error: builder for '/nix/store/rzgjh2hfqw3w1i2xlfbq77mbizlhzdji-virtualbox-7.0.22-kvm-dev-20240828.patch.drv' failed with exit code 1;

@LeSuisse
Copy link
Contributor Author

Yes the failure of virtualboxKvm is expected according to the discussion in #350707

@bjornfor bjornfor mentioned this pull request Oct 28, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriedrichAltheide FriedrichAltheide FriedrichAltheide approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@blitz blitz Awaiting requested review from blitz

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeSuisse @bjornfor @FriedrichAltheide @parthy