Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sketchybar: switch to apple-sdk_15 #352620

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

sketchybar: switch to apple-sdk_15 #352620

wants to merge 3 commits into from
+10 −33

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Oct 31, 2024 •
edited
Loading

Things done

Bump SDK to 15, upstream uses available checks to determine functionality based on available SDK.
ie: https://github.com/FelixKratz/SketchyBar/blob/ed1684d348fc4d4319c7f9835141524c524bacb3/src/window.c#L240-L250

if (__builtin_available(macOS 14.0, *)) {

Minimum supported:

x86: CFLAGS+=-target x86_64-apple-macos10.13

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman khaneliman mentioned this pull request Oct 31, 2024
Closed
13 tasks
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352620

x86_64-darwin

✅ 1 package built:
  • sketchybar

aarch64-darwin

✅ 1 package built:
  • sketchybar

@khaneliman khaneliman changed the title sketchybar: switch to apple-sdk_11 sketchybar: switch to apple-sdk_15 Oct 31, 2024
@khaneliman
sketchybar: switch to apple-sdk_11
a268363
@khaneliman
sketchybar: add versionCheckHook
1278bdd 
Check version on build and skip calling --help since it doesn't return
version.
@khaneliman
sketchybar: apple_sdk-11 -> apple_sdk-15
c5d7cb7 
Upstream uses availability checks for different features. Lets not hold
back functionality by building with latest SDK available.
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352620

x86_64-linux

aarch64-linux

x86_64-darwin

✅ 1 package built:
  • sketchybar

aarch64-darwin

✅ 1 package built:
  • sketchybar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy Awaiting requested review from emilazy

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@khaneliman