drivers: regulator: read current level from the device #6662
Conversation
There was a problem hiding this comment.
Makes sense to me.
Nitpicking; reading again the commit message, maybe words "current level" can be confusing; this is about the current voltage level, not the current current level. I would suggest to either replace current level with effective level or explicit current voltage level what do you think? Or maybe:
drivers: regulator: do not cache voltage level value
...
This this fixes the regulator framework, I think it's worth adding a Fixes: tag:
Fixes: 1a3d3273040b ("drivers: regulator framework").
core/include/drivers/regulator.h
Outdated
| @@ -286,10 +284,7 @@ static inline TEE_Result regulator_set_min_voltage(struct regulator *regulator) | |||
| * regulator_get_voltage() - Get regulator current level in microvolt | |||
There was a problem hiding this comment.
I think we should rephrase this to Get regulator effective voltage level in microvolt.
but that out of the scope of your P-R.
patrickdelaunay
force-pushed
the
regulator
branch
2 times, most recently
from
b301451
to
423c992
Compare
done
done |
patrickdelaunay
force-pushed
the
regulator
branch
from
423c992
to
ef960cc
Compare
There was a problem hiding this comment.
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com> with minor fix in commit message:
"It is up the regulator driver to cache or not this value in its private data..."
or
"It is up the regulator drivers to cache or not this value in their private data..."
done |
Always read current voltage level from the device instead of caching the level in struct regulator. This fixes issues for when the regulator level value depends on the parent regulator (supply). It is up the regulator drivers to cache or not this value in their private data if applicable. Fixes: 1a3d327 ("drivers: regulator framework") Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
patrickdelaunay
force-pushed
the
regulator
branch
from
ef960cc
to
644bdb2
Compare
|
@jforissier, is this change ok to be merged? |
It is, sorry for not noticing. |
|
No worries. Thanks. |
Always read current voltage level from the device instead of caching the level in struct regulator. This fixes issues for when the regulator level value depends on the parent regulator (supply). It is up the regulator driver to cache or not this value in their private data if applicable.