Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test pydantic v2 #541

Merged
merged 11 commits into from
Sep 1, 2023
Merged

test pydantic v2 #541

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d94e91f
test pydantic v2
mikemhenry Aug 30, 2023
8a8889c
fix issues with mypy
mikemhenry Aug 30, 2023
e6b7442
Merge branch 'main' into feat/support_pydantic_v1_v2_for_real
mikemhenry Aug 31, 2023
f4e80ab
add one job that does only pydantic
mikemhenry Aug 31, 2023
c47af14
dumb hack
mikemhenry Aug 31, 2023
71a85c3
see how bad this looks, might just need to use an if statement
mikemhenry Sep 1, 2023
f87913e
forgot it needs to be an array
mikemhenry Sep 1, 2023
6b9cc9b
playing around with ci job names
mikemhenry Sep 1, 2023
f316719
why not emoji (V) (°,,,,°) (V)
mikemhenry Sep 1, 2023
f0f9f91
forgot a pydantic version number
mikemhenry Sep 1, 2023
5c311d2
I think the -> looks too much like an arrow
mikemhenry Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
- pytest-xdist
- pytest-cov
- pytest-rerunfailures
- pydantic <2
- pydantic >1
- coverage
- cinnabar ==0.3.0
- openff-toolkit>=0.13.0
Expand Down
2 changes: 1 addition & 1 deletion openfe/protocols/openmm_rfe/equil_rfe_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
try:
from pydantic.v1 import validator
except ImportError:
from pydantic import validator
from pydantic import validator # type: ignore[assignment]


class AlchemicalSettings(SettingsBaseModel):
Expand Down
2 changes: 1 addition & 1 deletion openfe/protocols/openmm_utils/omm_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
try:
from pydantic.v1 import validator
except ImportError:
from pydantic import validator
from pydantic import validator # type: ignore[assignment]

class SystemSettings(SettingsBaseModel):
"""Settings describing the simulation system settings."""
Expand Down
Loading