Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pydantic v2 #541

Merged
merged 11 commits into from
Sep 1, 2023
Merged

test pydantic v2 #541

merged 11 commits into from
Sep 1, 2023

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Aug 30, 2023

Developers certificate of origin

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (ab271ba) 90.99% compared to head (5c311d2) 91.00%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   90.99%   91.00%   +0.01%     
==========================================
  Files         114      114              
  Lines        6882     6891       +9     
==========================================
+ Hits         6262     6271       +9     
  Misses        620      620              
Files Changed Coverage Δ
openfe/protocols/openmm_rfe/equil_rfe_settings.py 100.00% <100.00%> (ø)
openfe/protocols/openmm_utils/omm_settings.py 84.48% <100.00%> (ø)
openfe/setup/ligand_network_planning.py 100.00% <100.00%> (ø)
openfe/tests/setup/test_network_planning.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry mikemhenry marked this pull request as ready for review August 30, 2023 20:20
@mikemhenry
Copy link
Contributor Author

This PR now actually sets us to pull in pydantic v2, but we use a pydantic.v1 import so we can support either. Do we want to add one CI job that checks to make sure things pass with pydantic <2? I was thinking that I could add a linux python 3.11 test for that

@richardjgowers
Copy link
Contributor

@mikemhenry yeah a single job for v1 sounds good

@mikemhenry
Copy link
Contributor Author

Cool I will add that then!

@mikemhenry mikemhenry marked this pull request as draft August 31, 2023 15:13
@mikemhenry
Copy link
Contributor Author

@richardjgowers that worked, it messed up the names of the jobs a bit, is that okay?

@mikemhenry
Copy link
Contributor Author

I'll do the same for gufe whatever we decide here

@richardjgowers
Copy link
Contributor

@mikemhenry yeah I can't remember if there was a nice way to label what "<2" meant in the build matrix but it's functionally great right now at least

@mikemhenry mikemhenry marked this pull request as ready for review September 1, 2023 20:55
@mikemhenry mikemhenry merged commit 6f91cbc into main Sep 1, 2023
8 checks passed
@mikemhenry mikemhenry deleted the feat/support_pydantic_v1_v2_for_real branch September 1, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants