-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test pydantic v2 #541
test pydantic v2 #541
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
==========================================
+ Coverage 90.99% 91.00% +0.01%
==========================================
Files 114 114
Lines 6882 6891 +9
==========================================
+ Hits 6262 6271 +9
Misses 620 620
☔ View full report in Codecov by Sentry. |
This PR now actually sets us to pull in pydantic v2, but we use a pydantic.v1 import so we can support either. Do we want to add one CI job that checks to make sure things pass with |
@mikemhenry yeah a single job for v1 sounds good |
Cool I will add that then! |
@richardjgowers that worked, it messed up the names of the jobs a bit, is that okay? |
I'll do the same for gufe whatever we decide here |
@mikemhenry yeah I can't remember if there was a nice way to label what "<2" meant in the build matrix but it's functionally great right now at least |
Developers certificate of origin