-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Pipeline Executor #18
Conversation
@hobu or @jimmysoda - since this is a relatively major change - it would be very good to get a review if you have the time |
@@ -26,11 +26,13 @@ | |||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | |||
* POSSIBILITY OF SUCH DAMAGE. | |||
*****************************************************************************/ | |||
|
|||
#define _CRT_SECURE_NO_WARNINGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is usually done with compile-time definitions instead of sticking it here, but i'm not much of a windows dev
In the absence of any comment from @jimmysoda - I am going to go ahead and merge |
@abellgithub - could you possibly "spot me" as they would say in climbing (i.e. check my reasoning) since I am to a large extent reverse engineering some stuff here : About null terminating strings etc as per review comment5s:
Is my logic valid? Thanks |
Changes to Move from pdal::PipelineExector to pdal::PipelineManager since the former is deprecated.
Also - extended the ABI to include streamable execution.