Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Pipeline Executor #18

Merged
merged 18 commits into from
Feb 6, 2023
Merged

Remove Pipeline Executor #18

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
656141f
first pass
runette Jan 31, 2023
d7e44d8
first compiling
runette Jan 31, 2023
9308314
Update pdalc_pipeline.cpp
runette Feb 1, 2023
093eba5
astyle changes
runette Feb 1, 2023
82409b2
fix compile warnings
runette Feb 1, 2023
e159fda
Update test_pdalc_config.c
runette Feb 1, 2023
03c20ab
Revert "Update test_pdalc_config.c"
runette Feb 1, 2023
ab9b97f
Update test_pdalc_config.c
runette Feb 1, 2023
4e451bb
Added streaming interface
runette Feb 1, 2023
0093cdf
documentation fixes
runette Feb 1, 2023
6899590
remove lint
runette Feb 3, 2023
8616cec
improved pointer handling
runette Feb 3, 2023
47ebb45
Update CHANGELOG.md
runette Feb 3, 2023
44994c3
improve readability after review
runette Feb 3, 2023
9bc256b
fixup null terminated strings
runette Feb 4, 2023
445b415
fixup null terminating strings 2
runette Feb 4, 2023
7c6bf38
strlen and fix schema
runette Feb 4, 2023
31aad74
astyle
runette Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/pdal/pdalc_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
* POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/

#define _CRT_SECURE_NO_WARNINGS
#include "pdalc_config.h"

#include <cstdlib>
Expand All @@ -36,6 +37,8 @@
#include <pdal/pdal_config.hpp>
#include <pdal/util/Utils.hpp>



namespace pdal
{
namespace capi
Expand Down
1 change: 1 addition & 0 deletions source/pdal/pdalc_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

#include "pdalc_forward.h"


/**
* @file pdalc_config.h
* Functions to retrieve PDAL version and configuration information.
Expand Down
4 changes: 3 additions & 1 deletion source/pdal/pdalc_dimtype.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/

#define _CRT_SECURE_NO_WARNINGS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is usually done with compile-time definitions instead of sticking it here, but i'm not much of a windows dev

#include "pdal/pdalc_dimtype.h"

#include <pdal/DimType.hpp>



namespace pdal
{
namespace capi
Expand Down
4 changes: 2 additions & 2 deletions source/pdal/pdalc_forward.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
namespace pdal
{
struct DimType;
class PipelineExecutor;
class PipelineManager;
class PointView;
class TriangularMesh;

Expand All @@ -64,10 +64,10 @@ using MeshPtr = std::shared_ptr<TriangularMesh>;
namespace capi
{
class PointViewIterator;
using Pipeline = std::unique_ptr<pdal::PipelineExecutor>;
using PointView = pdal::PointViewPtr;
using TriangularMesh = pdal::MeshPtr;
using DimTypeList = std::unique_ptr<pdal::DimTypeList>;

}
}

Expand Down
Loading