Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mitocholide fix #27103

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

ErdGinalD
Copy link
Contributor

What Does This PR Do

Fixes #26996

Why It's Good For The Game

Bugs are bad. Except Kidans.

Images of changes

Subject
image

How it works now
image

How it works after fix
image

Testing

Deal 1111 to doll, check in scaner, delimb his arms, splash mito on them, detach back, cheking, all good.
Make this corpse a zombie, check in scanner, all organs dead, but not broken. Wounds are not closed up.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Mitocholide are now healing detached limbs again
/:cl:

Allow ghost to track blob overmind.
Copy link
Contributor

@BiancaWilkson BiancaWilkson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something might be up with your branch, you're somehow changing config.toml

@ErdGinalD
Copy link
Contributor Author

Something might be up with your branch, you're somehow changing config.toml

yeah, i accidentaly mess up. All good now

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 14, 2024
Comment on lines +397 to +400
if(owner && !HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS)) // zombies's wounds don't close. Because thats cool.
open = ORGAN_CLOSED
else
open = ORGAN_CLOSED //Closing all wounds for detached limbs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want this, because otherwise you're making it so zombie limbs will close

Suggested change
if(owner && !HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS)) // zombies's wounds don't close. Because thats cool.
open = ORGAN_CLOSED
else
open = ORGAN_CLOSED //Closing all wounds for detached limbs.
if(!owner || !HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS)) // zombies's wounds don't close. Because thats cool.
open = ORGAN_CLOSED //Closing all wounds for detached limbs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
your variant doesnt help zombies.

Copy link
Contributor Author

@ErdGinalD ErdGinalD Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detached limbs doesnt have owner, so they runtime on this path and doesnt continue code at all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
this code also doesnt work somehow. Why..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't resolve conversations from a maintainer without them saying it can be closed (if the review isn't applied)
In this case, the else statement made every dropped limb closed regardless of the if statement, while we want dropped limbs from zombies or with owners to stay open.

@DGamerL DGamerL removed the request for review from AffectedArc07 October 14, 2024 21:54
@Henri215 Henri215 added the Fix This PR will fix an issue in the game label Oct 15, 2024
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See contra review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/obj/item/organ/external/rejuvenate() throw an runtime, when you splash mitocholide on dismembered limb
7 participants