-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] mitocholide fix #27103
base: master
Are you sure you want to change the base?
[FIX] mitocholide fix #27103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something might be up with your branch, you're somehow changing config.toml
yeah, i accidentaly mess up. All good now |
if(owner && !HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS)) // zombies's wounds don't close. Because thats cool. | ||
open = ORGAN_CLOSED | ||
else | ||
open = ORGAN_CLOSED //Closing all wounds for detached limbs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want this, because otherwise you're making it so zombie limbs will close
if(owner && !HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS)) // zombies's wounds don't close. Because thats cool. | |
open = ORGAN_CLOSED | |
else | |
open = ORGAN_CLOSED //Closing all wounds for detached limbs. | |
if(!owner || !HAS_TRAIT(owner, TRAIT_I_WANT_BRAINS)) // zombies's wounds don't close. Because thats cool. | |
open = ORGAN_CLOSED //Closing all wounds for detached limbs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detached limbs doesnt have owner, so they runtime on this path and doesnt continue code at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't resolve conversations from a maintainer without them saying it can be closed (if the review isn't applied)
In this case, the else
statement made every dropped limb closed regardless of the if
statement, while we want dropped limbs from zombies or with owners to stay open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See contra review
What Does This PR Do
Fixes #26996
Why It's Good For The Game
Bugs are bad. Except Kidans.
Images of changes
Subject
How it works now
How it works after fix
Testing
Deal 1111 to doll, check in scaner, delimb his arms, splash mito on them, detach back, cheking, all good.
Make this corpse a zombie, check in scanner, all organs dead, but not broken. Wounds are not closed up.
Declaration
Changelog
🆑
fix: Mitocholide are now healing detached limbs again
/:cl: