-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] mitocholide fix #27103
Open
ErdGinalD
wants to merge
29
commits into
ParadiseSS13:master
Choose a base branch
from
ErdGinalD:FIX-mithocolide
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−3
Open
[FIX] mitocholide fix #27103
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b7d4f03
Slight Pump Up nerf
ErdGinalD 4e47b49
Merge remote-tracking branch 'upstream/master'
ErdGinalD 99f72ed
Merge remote-tracking branch 'upstream/master'
ErdGinalD 69f7330
Merge remote-tracking branch 'upstream/master'
ErdGinalD 85702c6
Merge remote-tracking branch 'upstream/master'
ErdGinalD 924647d
Merge remote-tracking branch 'upstream/master'
ErdGinalD 2c8457c
FIX: Now you can observe blob overmind
ErdGinalD db9ad95
Deleting unnecessary armor from explorer gear
ErdGinalD c6b7beb
Merge branch 'master' of https://github.com/ErdGinalD/Off-para
ErdGinalD 18e26f1
Revert "Deleting unnecessary armor from explorer gear"
ErdGinalD 618c7d1
Revert "Merge branch 'master' of https://github.com/ErdGinalD/Off-para"
ErdGinalD 3d804c7
Merge remote-tracking branch 'upstream/master'
ErdGinalD 799f138
Merge remote-tracking branch 'upstream/master'
ErdGinalD 8670a59
Merge remote-tracking branch 'upstream/master'
ErdGinalD 02fc40a
Merge remote-tracking branch 'upstream/master'
ErdGinalD 340979f
Merge remote-tracking branch 'upstream/master'
ErdGinalD cd9f9a2
Merge remote-tracking branch 'upstream/master'
ErdGinalD a031785
Merge remote-tracking branch 'upstream/master'
ErdGinalD f40e1d8
Merge remote-tracking branch 'upstream/master'
ErdGinalD 109a233
Merge remote-tracking branch 'upstream/master'
ErdGinalD 8b2f4d9
Update config.toml
ErdGinalD 67d721a
Merge remote-tracking branch 'upstream/master'
ErdGinalD 3d4f10a
Merge remote-tracking branch 'upstream/master'
ErdGinalD 92b3b5d
Merge remote-tracking branch 'upstream/master'
ErdGinalD 3f11846
Merge remote-tracking branch 'upstream/master'
ErdGinalD 82e57bf
Merge remote-tracking branch 'upstream/master'
ErdGinalD 0969880
Merge remote-tracking branch 'upstream/master'
ErdGinalD 2f86553
FIX for Mithocolidde
ErdGinalD 934dcb6
Update config.toml
ErdGinalD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want this, because otherwise you're making it so zombie limbs will close
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your variant doesnt help zombies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detached limbs doesnt have owner, so they runtime on this path and doesnt continue code at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code also doesnt work somehow. Why..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't resolve conversations from a maintainer without them saying it can be closed (if the review isn't applied)
In this case, the
else
statement made every dropped limb closed regardless of theif
statement, while we want dropped limbs from zombies or with owners to stay open.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zombies cant drop limbs because of their feature, so we need close wounds for all, except zombie limbs on their owner.
For me, better just delete this "feature", this is pointless if compare to mito broken interaction