[WIP][Bug Fix] Fixing the pow method on qml.TShift
#6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
astralcai
reviewed
Oct 8, 2024
| @@ -168,7 +173,7 @@ def test_no_pow_ops(self, op): | |||
| assert len(op_pow) == 1 | |||
| assert op_pow[0].__class__ == op.__class__ | |||
|
|
|||
| pows = [0.1, 2, -2, -2.5] | |||
| pows = [0.1, -2.5] | |||
There was a problem hiding this comment.
Suggested change
| pows = [0.1, -2.5] | |
| pows = [0.1, -2, -2.5] |
There was a problem hiding this comment.
-2 should not raise PowUndefinedError since -2 % 4 = 2 is what gets passed into pow which is now defined. Maybe this test is not necessary since THadamard is tested in test_period_two_three_noninteger_power 🤔
There was a problem hiding this comment.
Oh I just realized that this is a test for qutrit ops
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
willjmax
changed the title
pow method on qml.TShiftpow method on qml.TShift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #6355 by providing proper
powimplementations forqml.TShift,qml.TAdd, andqml.TClock. Each of these operators implementpowin the following way.This is calling the
powmethod onOperatorwhich handles the cases forz==0andz==1but returns aPowUndefinedErrorfor any other value ofz. This leads to an error forTShift,TAdd, andTClockwhen raising to the second power. This PR implements the case whenzis a non-negative integer by returning a list containingzcopies of the operator.