-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Bug Fix] Fixing the pow
method on qml.TShift
#6356
Open
willjmax
wants to merge
17
commits into
master
Choose a base branch
from
tshift-pow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d36c38d
fixing pow
willjmax 3a18d88
formatting and changelog
willjmax 4e835b5
changes to operator pow and tests
willjmax 8d927b6
modifed tests
willjmax 5fd4210
Merge branch 'master' into tshift-pow
willjmax 138358c
removing unused import
willjmax a2380db
Merge branch 'tshift-pow' of github.com:PennyLaneAI/pennylane into ts…
willjmax f3b5efd
formatting
willjmax 2228895
update pow for operator
willjmax f9a3c06
remove comment
willjmax 20c120f
removing recursion
willjmax d925d6a
Merge branch 'tshift-pow' of github.com:PennyLaneAI/pennylane into ts…
willjmax f800b0f
removing unneeded comment
willjmax b0e8ec9
updating changelog
willjmax 076394b
Merge branch 'master' into tshift-pow
willjmax bfda01e
Merge branch 'master' into tshift-pow
willjmax 6c06284
Merge branch 'master' into tshift-pow
willjmax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-2
should not raisePowUndefinedError
since-2 % 4 = 2
is what gets passed intopow
which is now defined. Maybe this test is not necessary sinceTHadamard
is tested intest_period_two_three_noninteger_power
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the
%4
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I just realized that this is a test for qutrit ops