-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
59 report tlf #110
59 report tlf #110
Conversation
…cy tables to also output title and footnotes.
is this still being worked on? |
Yes. I'll need to generate this after the final run. |
…ts display on the same page under the Table 14-3.01 and (sequentially with pagination) Table 14-3.02 headers. Set KM Plot fig.align and out.width r plot property values. Modified footers for KM Plot and Demographic Table to comply with the June 2023 FDA Guidelines.
Hi @laxamanaj - please review. As noted the use of \includegraphics does address the issue you raised at last Friday's Check-In. Thanks. Summary: [Cf. knitr::include_graphics( ) also addresses the issue.] Thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment regarding Table 14-3.02 output.
# print(tbl) | ||
``` | ||
|
||
\includegraphics[page=1]{/cloud/project/submission/output/tlf-efficacy-pilot3.rtf.pdf} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @robertdevine . When I pulled this branch and ran the .Rmd, Table 14-3.02 was off center in the report-tlf-pilot3.pdf that I generated. Is this the same with yours? See below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @laxamanaj
closes #59 |
I'm working with with @robertdevine and @pstata to look into this report-tlf.pdf generation per #59 . The goal we are trying to accomplish is to output the same report-tlf.pdf as pilot 1, here : https://github.com/RConsortium/submissions-pilot1-to-fda/blob/main/m1/us/report-tlf.pdf
The updates I want to show is that we included the timestamps in the footnote, showing that we did rerun these for pilot 3 at the time of submission.
When you pull this branch, you'll see I started an report-tlf-pilot3.Rmd here :
/submissions/programs/report-tlf-pilot3.Rmd
. Right now as it runs the demog table and the kmplot seem to come out ok. The demog table could use some minor adjusting so the header lines don't wrap over.As you see in the
/submissions/programs/report-tlf-pilot3.Rmd
, I want to be able to source our first line programs from ourprograms
folder to output in one markdown pdf file so that we keep the program files as the single source of truth.When running this .Rmd, the
report-tlf-pilot3.pdf
will save in the programs folder. At the same time it also runs all of the table programs and updates them in the output folder. In this way the timestamps will always match up in the output folder and the finalreport-tlf-pilot3.pdf
The tables primary and efficacy, I am having a bit of trouble outputting with the titles and footnotes as they show in their original .rtf outputs. If someone can help look into this to bring this
report-tlf.pdf
similar to pilot 1, that is the goal.to summarize fixes needed to show in this R markdown :
report-tlf-pilot3.pdf
get saved in ouroutput
folder programmatically (e.g. maybe there is r markdownoutput=[file path]
argument we can add)?.I plan to meet with Robert and Phani tomorrow, but want to tag in @DeclanHodges @thomas-neitmann in this review to see if they have any ideas to resolve the issues mentioned above, since they'll be logging in soon in EU.
Thanks in advance.
Joel