-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New fill kernel and validation tolerances #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far. I had a discussion with @CongMa13 and I we should add back in a seed value because each thread's hash value is deterministic. We don't want fill values to be the same for same-sized tensors. We can differentiate them at least by seeding different values for different tensors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all tests pass
Implements the new fill kernel from PR 236 with supporting changes to the validation thresholds used throughout the testing infrastructure. The new validation thresholds should guarantee that validating CK kernels will also validate when used within hipTensor.