New fill kernel and validation tolerances #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlangbe
requested review from
cgmillette,
bragadeesh,
mkarunan,
CongMa13 and
afanfa
as code owners
cgmillette
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Looks great so far. I had a discussion with @CongMa13 and I we should add back in a seed value because each thread's hash value is deterministic. We don't want fill values to be the same for same-sized tensors. We can differentiate them at least by seeding different values for different tensors.
CongMa13
reviewed
Jul 26, 2024
CongMa13
reviewed
Jul 29, 2024
cgmillette
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the new fill kernel from PR 236 with supporting changes to the validation thresholds used throughout the testing infrastructure. The new validation thresholds should guarantee that validating CK kernels will also validate when used within hipTensor.