Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.4] AOTriton build refactor: download binary from github, NO BUILD FROM SOURCE option #1626

Draft
wants to merge 2 commits into
base: release/2.4
Choose a base branch
from

Conversation

jithunnair-amd
Copy link
Collaborator

  • AOTriton build refactor: download binary from github, NO BUILD FROM SOURCE option
  • Copy AOTRITON_INSTALLED_PREFIX/* to torch/, Otherwise bdist_wheel will miss libaotriton_v2.so
  • Move all aotriton_version.txt info to aotriton.cmake
  • Consider ROCm version to pick up right tarball
  • Supply ROCM versions and SHA256 checksums as lists.

Changes cherry-picked from pytorch#137443

@rocm-mici
Copy link

Jenkins build for a3ef66bc6f4f3b4f6749e026d09855267dd95e00 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

    Fix tarball's suffix

    Read rocm version from variables set by LoadHIP.cmake

    Copy AOTRITON_INSTALLED_PREFIX/* to torch/

    Otherwise bdist_wheel will miss libaotriton_v2.so

    Fix problems in aotriton.cmake

    Guard against new ROCM environment

    This also updates aotriton_version.txt's format

    Supply ROCM versions and SHA256 checksums as lists.

    Let install_aotriton.sh parse the new format of aotriton_version.txt

    Do not hardcode __AOTRITON_ARCH

    Updates to aotriton build steps and Dockerfiles (#1599)

Changes cherry-picked from pytorch#137443
@jithunnair-amd jithunnair-amd force-pushed the release/2.4_aotriton_build_refactor branch from a3ef66b to c30d565 Compare October 9, 2024 05:48
@rocm-mici
Copy link

Jenkins build for c30d565bdde8592331f374c3bc9de3fffc157f97 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-mici
Copy link

Jenkins build for c30d565bdde8592331f374c3bc9de3fffc157f97 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-mici
Copy link

Jenkins build for c30d565bdde8592331f374c3bc9de3fffc157f97 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants