-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move createjs.com to Github #3
Open
owendwyer
wants to merge
7
commits into
ReCreateJS:master
Choose a base branch
from
owendwyer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
88e1573
Update and rename 0000-template.md to text/0000-redeploy-website.md
owendwyer 80511bb
Create 0000-template.md
owendwyer aea079e
Update 0000-redeploy-website.md
owendwyer b29e5fb
Update 0000-redeploy-website.md
owendwyer 2edb5e1
Update and rename 0000-redeploy-website.md to 0003-redeploy-website.md
owendwyer 9f456a3
Update 0000-template.md
owendwyer 7cfb94c
Update 0000-template.md
owendwyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
- Start Date: 2020-03-12 | ||
- RFC PR: https://github.com/ReCreateJS/rfcs/pull/3 | ||
- Relevant Project: All CreateJS | ||
|
||
# Redeploy Website | ||
|
||
## Summary | ||
|
||
Move the createjs.com home page so that it is hosted on Github. | ||
|
||
## Motivation | ||
|
||
The createjs homepage is an essential part of the project. It has information for users, tutorials, demonstrations and a link to the current build of each module and the combined build. Notably, the current and combined builds have not been updated to reflect updates to the source files. The home page needs to be maintained and updated. | ||
|
||
## Detailed design | ||
|
||
1. Create a new repository in the CreateJS space called HomePage. | ||
|
||
2. Copy all the website files to that repo. | ||
|
||
3. On Github settings, add createjs.com as a custom domain that points to that repo. | ||
|
||
4. Update the DNS for createjs.com so that it is served by Github. | ||
|
||
## Drawbacks | ||
|
||
It's hard to know what GrantSkinner will think about this and whether they'd be okay with giving up the keys to the homepage. Maybe it has some IP value. | ||
|
||
## Justification | ||
|
||
The advantage of hosting it on Github is that changes can be made by consensus and in a transparent way. The homepage would be maintained in the same way that the source files. This would allow people to view and comment on any changes. | ||
|
||
## Alternatives | ||
|
||
An alternative would be for someone who works at GrantSkinner to make changes as requested. | ||
|
||
Another option would be to make a new homepage for createjs with a new domain name. But even if that is done, it would still be a good idea to host it on Github. | ||
|
||
## Unresolved questions | ||
|
||
I'm assuming that the homepage is a static site that just includes HTML, javascript, css and images. | ||
|
||
It would be good to check how the site was initially built. Looks like Bootstrap was used. I don't know if any other generating software was used to build the html files or whether each page was manually created. Looking at the number of pages and simplicity, I think it could be feasible to just edit it in place rather than rebuilding from any source. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have these lines intentionally been removed? If so - what is the thinking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was unintentional. I moved the default file when I should have copied it.