Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dedicated fold and rfold impls for iterators #280

Merged
merged 1 commit into from
Jun 4, 2024
Merged

add dedicated fold and rfold impls for iterators #280

merged 1 commit into from
Jun 4, 2024

Conversation

oskgo
Copy link
Contributor

@oskgo oskgo commented May 29, 2024

Fixes #277

@oskgo
Copy link
Contributor Author

oskgo commented May 29, 2024

I tried benchmarking it as well, but there were server connection issues.

@Kerollmops Kerollmops mentioned this pull request May 30, 2024
Merged
Kerollmops
Kerollmops requested changes May 30, 2024
View reviewed changes
src/treemap/iter.rs Outdated Show resolved Hide resolved
@oskgo
add dedicated fold and rfold impls
73714f8 
add test for `fold`

also add test for treemap

use closures directly
Kerollmops
Kerollmops approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes!

@Kerollmops Kerollmops merged commit 2288f7c into RoaringBitmap:main Jun 4, 2024
4 checks passed
@oskgo oskgo deleted the fix-277 branch June 6, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override default fold and rfold implementations for the iterators
2 participants
@oskgo @Kerollmops