Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for SQLException when getting object from SQLite storage #248

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Check for SQLException when getting object from SQLite storage #248

merged 2 commits into from
Oct 11, 2023

Conversation

danilo04
Copy link
Contributor

@danilo04 danilo04 commented Oct 10, 2023 •
edited
Loading

On Simplenote, we get crashes when a note is big and exceeds the SQLite row size (2 MB). We are going to catch SQLException and return a missing object for the cases in which we get an exception.

@danilo04 danilo04 marked this pull request as ready for review October 10, 2023 14:09
@danilo04 danilo04 mentioned this pull request Oct 10, 2023
Merged
@AmandaRiu AmandaRiu self-assigned this Oct 10, 2023
AmandaRiu
AmandaRiu approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 :shipit:

@AliSoftware AliSoftware merged commit 11e14c0 into trunk Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmandaRiu AmandaRiu AmandaRiu approved these changes

Assignees

@AmandaRiu AmandaRiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danilo04 @AmandaRiu @AliSoftware