Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listmode DL notebooks for PSMR 2024 #225

Merged
merged 55 commits into from
May 16, 2024

Conversation

gschramm
Copy link
Contributor

Don't merge yet, because:

@gschramm
Copy link
Contributor Author

@KrisThielemans for adding the LM caching:

  • here is where I setup the ListModeData object
  • here is where I setup the listmode logL and reconstruct

@KrisThielemans
Copy link
Member

Some quick comments:

@gschramm
Copy link
Contributor Author

  1. Isn't it the easiest / most efficient if we only unlist + reconstruct the complete (1m and 60min) list mode files. Should avoid all kind of problems ...
  2. is the "large number" in bytes / MB / GB?
  3. Just starting reconstructing the 60min data after downloading. But I immediately get this error when reading the mumap file:
attn_image = sirf.STIR.ImageData("../../data/PET/mMR/NEMA_IQ/20170809_NEMA_MUMAP_UCL.v.hdr")

error: ??? '\'\\nERROR: Error parsing: expected a vectorised key as in "image duration (sec)[1]", but no bracket found\\n\' 
exception caught at line 417 of /users/nexuz/gschra2/nge/SIRF/build_lm/sources/SIRF/src/xSTIR/cSTIR/cstir.cpp; the reconstruction engine output may provide more information'

The header looks like this:

!IMAGE DATA DESCRIPTION:=
!total number of data sets:=1
!image duration (sec):=0
!image relative start time (sec):=0

@KrisThielemans
Copy link
Member

  1. sure
  2. bytes
  3. yes, the full notebook contains extra stuff to handle this, but easiest is to use the same attenuation image and norm (or indeed acq_sens_model) as for the 1 min data. Note that there will be scale factor of 60 (or nearly, due to decay) between the images, as that's currently not yet taken into account.

@gschramm
Copy link
Contributor Author

Thanks Kris! Will update the notebooks accoordingly tmr.
To take care of the scale difference for the 60min ref. image, I will probably just rescale based on the mean intensity.

@KrisThielemans
Copy link
Member

I'll merge this in a few minutes

@gschramm
Copy link
Contributor Author

gschramm commented May 16, 2024

@KrisThielemans ready to be merged

@KrisThielemans
Copy link
Member

squash or not? As you prefer

@gschramm
Copy link
Contributor Author

please squash, but let me fix one typo before

@gschramm
Copy link
Contributor Author

@KrisThielemans : typos fixed, ready to be squashed and merged

@KrisThielemans KrisThielemans merged commit ec5215b into SyneRBI:master May 16, 2024
@gschramm gschramm deleted the LM_DL_notebooks branch May 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants