Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GECKO 3.2.1 #383

Merged
merged 1 commit into from
Jun 7, 2024
Merged

GECKO 3.2.1 #383

merged 1 commit into from
Jun 7, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jun 7, 2024

  • Fixes:
    • getStandardKcat.m removed enzymes when it was run on a model already containing standard kcat values
    • ecFVA will swap min and max values the reaction directionality was swapped when mapping from ec- to conventional model
    • plotEcFVA will use its own cdfplot function, to avoid dependency on MATLAB Statistics and Machine Learning Toolbox. Blocked reactions are excluded from the graph. ⚠️ The plot in full_ecModel shows minor differences, also due to code changes introduced by GECKO 3.2.0
  • Features:
    • ´calculateFfactorcan handleprotData` with multiple conditions (in which case, averages over all conditions are taken)
    • setKcatForReactions allows multiple kcat values as input, allowing to set kcat of multiple reactions at the same time
    • reportEnzymeUsage will report both the summed usage of isoenzymes, as well as the individual usage of the separate reactions. topUsage and highCapUsage outputs columns are harmonized
    • constrainFluxData if a provided constraint is either -1000 or 1000, lower and upper bound will be constraint to either uptake or excretion only, irrespective of what option is given as the looseStrictFlux parameter
    • constrainEnzConcs can also remove enzyme concentration constraints
  • Refactor:
    • fuzzyKcatMatching to avoid warnings "Colon operands must be real scalars" in recent MATLAB versions
  • Documentation:
    • various function documentations, warnings and error messages have been improved

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

…onstrainFluxData (#382)

* fix: getECfromDatabase correct input parameter doc

* feat: makeEcModel error if none of proteins match

* fix: getStandardKcat not remove if real enzyme

* style: various

* todo: refactor fuzzyKcatMatching to use regexprep

* fix: calculateFfactor handle protData multi conds

* fix getStandardKcat

* feat: setKcatForReactions allows multiple kcat as input

* feat: reportEnzymeUsage if enzyme cat. more rxns

* chore: updateGECKOdoc

* fix: reportEnzymeUsage correct percUsage

* fix: constrainFluxData (-)1000 constraints

* fix: ecFVA correct swapped rev fluxes

* fix: reportEnzymeUsage highUsage split isozymes

* refactor: fuzzyKcatMatching use regexprep

* fix: plotEcFVA cdfplot and only plot non-zero rxns

* feat: constrainEnzConcs can remove enzConstraints

* chore: rerun tutorials

* fix: getStandardKcat for light ecModels

* fix: constrainEnzConcs remove enz constraints
@edkerk edkerk changed the title fix/feat: various, including ecFVA, enzymeUsage, constrainEnzConcs, c… GECKO 3.2.1 Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
GECKO version 3.2.0 installed
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit bbb4e9e into main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant