[BUGFIX] Do not consider "0" as empty in the CSV DB import #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A DB column value "0" is a perfectly valid value and should not be considered to be empty. Particularly, having a "0" value as the first value in a DB row in a CSV file should still allow the DB row to get importet. (In general, `empty()` in PHP behaves in mysterious ways and should be avoided in favor of more explicit and human-predicable checks.) Fixes #488 Releases: main, 7, 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DB column value "0" is a perfectly valid value and should not be considered to be empty.
Particularly, having a "0" value as the first value in a DB row in a CSV file should still allow the DB row to get importet.
(In general,
empty()in PHP behaves in mysterious ways and should be avoided in favor of more explicit and human-predicable checks.)Fixes #488
Releases: main, 7, 6