Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Do not consider "0" as empty in the CSV DB import #491

Merged
merged 1 commit into from
Aug 12, 2023
Merged

[BUGFIX] Do not consider "0" as empty in the CSV DB import #491

merged 1 commit into from
Aug 12, 2023

Commits on Aug 12, 2023

  1. [BUGFIX] Do not consider "0" as empty in the CSV DB import 

    A DB column value "0" is a perfectly valid value and should not be
considered to be empty.

Particularly, having a "0" value as the first value in a DB row
in a CSV file should still allow the DB row to get importet.

(In general, `empty()` in PHP behaves in mysterious ways and should
be avoided in favor of more explicit and human-predicable checks.)

Fixes #488

Releases: main, 7, 6
    @oliverklee @lolli42
    oliverklee authored and lolli42 committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    ffbc358 View commit details
    Browse the repository at this point in the history