Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button): 组件对齐 mobile-vue #464

Closed
wants to merge 9 commits into from

Conversation

tobytovi
Copy link
Collaborator

@tobytovi tobytovi commented Aug 16, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

相关的common仓库PR:
Tencent/tdesign-common#1883

💡 需求背景和解决方案

同步 tdesign-mobile-vue 能力到 tdesign-mobile-react
使其能力一致,本次同步Button组件部分

image

📝 更新日志

  • fix(Button): 同步tdesign-mobile-vue的Button组件样式到tdesign-mobile-react

  • fix(Button): 修正虚框按钮的样式,对齐figma设计稿

  • fix(Demo): 同步tdesign-mobile-vue的Button的演示样式到tdesign-mobile-react

  • fix(Demo): 新增虚框按钮的样式演示

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@tobytovi tobytovi changed the title feat(Button): 组件对齐 mobile-vue [WIP]feat(Button): 组件对齐 mobile-vue Aug 16, 2024
@tobytovi tobytovi changed the title [WIP]feat(Button): 组件对齐 mobile-vue feat(Button): 组件对齐 mobile-vue Aug 16, 2024
Copy link
Contributor

github-actions bot commented Aug 16, 2024

失败

@liweijie0812
Copy link
Collaborator

创建 PR

在同步官方仓库代码后,请从 develop 分支(TDesign 仓库均以 develop 作为默认最新的开发分支)创建新的 feat/fix 分支:

git checkout develop
git checkout -b feat/xxx

feat 指代新特性如新组件或者组件新功能,日常问题修复以 fix 开头。

https://tdesign.tencent.com/about/contributing#%E5%88%9B%E5%BB%BA-pr

@tobytovi
Copy link
Collaborator Author

创建 PR

在同步官方仓库代码后,请从 develop 分支(TDesign 仓库均以 develop 作为默认最新的开发分支)创建新的 feat/fix 分支:

git checkout develop git checkout -b feat/xxx

feat 指代新特性如新组件或者组件新功能,日常问题修复以 fix 开头。

https://tdesign.tencent.com/about/contributing#%E5%88%9B%E5%BB%BA-pr

创建 PR

在同步官方仓库代码后,请从 develop 分支(TDesign 仓库均以 develop 作为默认最新的开发分支)创建新的 feat/fix 分支:

git checkout develop git checkout -b feat/xxx

feat 指代新特性如新组件或者组件新功能,日常问题修复以 fix 开头。

https://tdesign.tencent.com/about/contributing#%E5%88%9B%E5%BB%BA-pr

已处理,重新提交到新的PR:
#469

@tobytovi
Copy link
Collaborator Author

已处理,重新提交到新的PR:
#469

@tobytovi tobytovi closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants