Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button): Button组件对齐 mobile-vue #469

Merged
merged 21 commits into from
Aug 21, 2024

Conversation

tobytovi
Copy link
Collaborator

@tobytovi tobytovi commented Aug 19, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

相关的common仓库PR:
Tencent/tdesign-common#1883

💡 需求背景和解决方案

同步 tdesign-mobile-vue 能力到 tdesign-mobile-react
使其能力一致,本次同步Button组件部分

image

📝 更新日志

  • feat(Button): 新增 loadingPropssuffix 属性

  • fix(Button): 修复虚框按钮样式错误

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@tobytovi tobytovi mentioned this pull request Aug 19, 2024
16 tasks
@tobytovi tobytovi changed the title feat(Button): 组件对齐 mobile-vue feat(Button): Button组件对齐 mobile-vue Aug 19, 2024
@tobytovi
Copy link
Collaborator Author

/update-snapshot

@tobytovi
Copy link
Collaborator Author

/update-common

@HaixingOoO
Copy link
Collaborator

/update-common

你本地运行npm run init看common更新嘛,不行就rebase develop

@tobytovi
Copy link
Collaborator Author

npm run init

我看你们都回复这个命令,我就试试有什么效果

@HaixingOoO
Copy link
Collaborator

npm run init

我看你们都回复这个命令,我就试试有什么效果

/update-snapshot是因为有时本地跑的snap和ci的对不上(有概率不同),所以用这个command来ci上跑多一次snap的

Copy link
Contributor

github-actions bot commented Aug 20, 2024

完成

@tobytovi
Copy link
Collaborator Author

/update-snapshot

@HaixingOoO
Copy link
Collaborator

/update-snapshot

src/button/Button.tsx Outdated Show resolved Hide resolved
@HaixingOoO
Copy link
Collaborator

@anlyyao 大佬,修复上面的类型,没问题了,然后你看看,你觉得也没问题就可以merge

@anlyyao
Copy link
Collaborator

anlyyao commented Aug 21, 2024

/update-snapshot

@anlyyao anlyyao merged commit f41bd72 into Tencent:develop Aug 21, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants