feat(cli): Add -ignoreReplaySyncErrors for diagnostic replay playback - #3152
Draft
bobtista wants to merge 3 commits into
Draft
feat(cli): Add -ignoreReplaySyncErrors for diagnostic replay playback#3152bobtista wants to merge 3 commits into
bobtista wants to merge 3 commits into
Conversation
bobtista
force-pushed
the
bobtista/feature/load-external-save-replay-files
branch
3 times, most recently
from
August 26, 2026 19:30
9659611 to
a10143d
Compare
bobtista
force-pushed
the
bobtista/feature/load-external-save-replay-files
branch
from
August 27, 2026 16:30
a10143d to
5199a06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of the original combined change. The absolute-path save loading is now #3226 and
-loadreplayis now #3227; what remains here is the synchronization-error switch alone.Replay playback reports a CRC mismatch through the UI and pauses. That is right for a player watching a replay, but it stops an unattended diagnostic run at the first divergence, which is exactly the point where the run needs to continue so the rest of the stream can be compared.
Now
-ignoreReplaySyncErrorslets playback continue past a mismatch, logging the frame and the two CRCs instead of reporting and pausing. It carries its own flag rather than reusing-ignoresync, which covers network synchronization, so replay playback keeps that flag's present behaviour.InGame:D9C721A5 Replay:D8A198C0 Frame:110)-ignoreReplaySyncErrorsTodo:
z_generalsandg_generals)-ignoreReplaySyncErrorscontinues past a mismatch