Skip to content

feat(cli): Add -ignoreReplaySyncErrors for diagnostic replay playback - #3152

Draft
bobtista wants to merge 3 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/feature/load-external-save-replay-files
Draft

feat(cli): Add -ignoreReplaySyncErrors for diagnostic replay playback#3152
bobtista wants to merge 3 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/feature/load-external-save-replay-files

Conversation

@bobtista

@bobtista bobtista commented Aug 15, 2026

Copy link
Copy Markdown

Split out of the original combined change. The absolute-path save loading is now #3226 and -loadreplay is now #3227; what remains here is the synchronization-error switch alone.

Replay playback reports a CRC mismatch through the UI and pauses. That is right for a player watching a replay, but it stops an unattended diagnostic run at the first divergence, which is exactly the point where the run needs to continue so the rest of the stream can be compared.

Now -ignoreReplaySyncErrors lets playback continue past a mismatch, logging the frame and the two CRCs instead of reporting and pausing. It carries its own flag rather than reusing -ignoresync, which covers network synchronization, so replay playback keeps that flag's present behaviour.

case result
Normal Replay synchronization reporting reports and pauses (InGame:D9C721A5 Replay:D8A198C0 Frame:110)
The same replay with -ignoreReplaySyncErrors continues past that mismatch without reporting or pausing

Todo:

  • Both games build (z_generals and g_generals)
  • Normal Replay synchronization reporting is unchanged without the flag
  • -ignoreReplaySyncErrors continues past a mismatch
  • Replicate to Generals

@bobtista bobtista self-assigned this Aug 15, 2026
@bobtista bobtista added Enhancement Is new feature or request Saveload Is Saveload/Xfer related labels Aug 15, 2026
@bobtista
bobtista force-pushed the bobtista/feature/load-external-save-replay-files branch 3 times, most recently from 9659611 to a10143d Compare August 26, 2026 19:30
@bobtista
bobtista force-pushed the bobtista/feature/load-external-save-replay-files branch from a10143d to 5199a06 Compare August 27, 2026 16:30
@bobtista bobtista changed the title feat(cli): Load save and replay files from absolute paths feat(cli): Add -ignoreReplaySyncErrors for diagnostic replay playback Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Is new feature or request Saveload Is Saveload/Xfer related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant