-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Playback times #196
base: dev
Are you sure you want to change the base?
Add Playback times #196
Conversation
@FelipeDefensor, need a little help on this one: tests.ui.cli.test_load_media |
Will look into it. |
Ok, so this is entirely on me. Contrary to what you would expect, the There were improvements to the tangled fixtures in v0.4.3, but apparently they were'nt enough. I will see if I can provide a permanent solution in the next few days. You can wait for that, or skip those tests with |
Marked skip for now. |
Easier than I thought, so I already pushed a commit to dev dealing with this. Will review this PR later today. |
Anne, sorry for the delay on the review. I was part of a congress today that took longer than I expected. Will review tomorrow, guaranteed. |
accidentally discarded - 97bf4aecd92f180f0e892e70c5e1c403f6aca096
display a subsection of input media. set through metadata window. ScaleOrCrop dialog replaces the old double dialog
eb30249
to
d8a5be6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is pretty clean and everything seems to be working. I tried to be more thorough than normal in the review as experience (or trauma) tells me that media loading bugs tend to be hard to spot.
I will try to write a billion tests for this. In the meantime, there are some minor issues to be adressed.
Good job!
remove unneccesary data & monkeypatching
elementry test on PointLikeTimelineComponent and SegmentLikeTimelineComponent
`pre_start` and `post_end` need to stored before changing `start` and `end`
Something goes wrong when scaling multiple a segmentlikes.
In that way components will have the same duration they were created in to be restored to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are perfect :).
Few new bugs I found:
- Pre-start and post-end were not being scaled correctly. I fixed that with a commit.
- Something goes wrong shen scaling multiple segmentlikes. I added a test for that behavior.
- Undoing a media load with scale or crop triggers the dialog again. We could either reset the undo history when loading a new media or somehow store whether the user chose the scale or crop options. I leave that up to you.
We are almost there!
#180, closes #178.
WIP:
fix CLI dialog