Add Playback times

tests/conftest.py

@@ -1,7 +1,6 @@
 import functools
 import sys
 from pathlib import Path
-from typing import Literal
 
 import pytest
 from PyQt6.QtWidgets import QApplication
@@ -24,6 +23,7 @@
 from tilia.ui.qtui import QtUI, TiliaMainWindow
 from tilia.ui.cli.ui import CLI
 from tilia.ui.windows import WindowKind
+from tilia.ui.dialogs.scale_or_crop import ScaleOrCrop
 from tilia.requests.get import reset as reset_get
 from tilia.requests.post import reset as reset_post
 
@@ -99,7 +99,11 @@ def duration(self):
     def duration(self, value):
         self.app.set_file_media_duration(value)
 
-    def set_duration(self, value, scale_timelines: Literal['yes', 'no', 'prompt'] = 'prompt'):
+    def set_duration(
+        self,
+        value,
+        scale_timelines: ScaleOrCrop.ActionToTake = ScaleOrCrop.ActionToTake.PROMPT,
+    ):
         """Use this if you want to pass scale_timelines."""
         self.app.set_file_media_duration(value, scale_timelines)
 
@@ -200,7 +204,7 @@ def add_timeline_with_post(kind: TimelineKind, name: str = ""):
             TimelineKind.HIERARCHY_TIMELINE: Post.TIMELINE_ADD_HIERARCHY_TIMELINE,
             TimelineKind.HARMONY_TIMELINE: Post.TIMELINE_ADD_HARMONY_TIMELINE,
             TimelineKind.BEAT_TIMELINE: Post.TIMELINE_ADD_BEAT_TIMELINE,
-            TimelineKind.AUDIOWAVE_TIMELINE: Post.TIMELINE_ADD_AUDIOWAVE_TIMELINE
+            TimelineKind.AUDIOWAVE_TIMELINE: Post.TIMELINE_ADD_AUDIOWAVE_TIMELINE,
         }
         with Serve(Get.FROM_USER_STRING, (name, True)):
             post(kind_to_request[kind])
@@ -219,14 +223,15 @@ def tlui(request, marker_tlui, harmony_tlui, beat_tlui, hierarchy_tlui, audiowav
         "harmony": harmony_tlui,
         "beat": beat_tlui,
         "hierarchy": hierarchy_tlui,
-        "audiowave": audiowave_tlui
+        "audiowave": audiowave_tlui,
     }[request.param]
 
 
 class UserActionManager:
     """
     Class to simulate and mock user interaction with the GUI.
     """
+
     def __init__(self):
         self.action_to_trigger_count = {}
         for action in tilia_actions_module.TiliaAction:

tests/file/test_file_manager.py

@@ -2,14 +2,15 @@
 from pathlib import Path
 from unittest.mock import mock_open
 import pytest
-from tests.mock import PatchPost, PatchGet, PatchGetMultiple, Serve
+from tests.mock import PatchPost, PatchGet, Serve
 from tilia.file.media_metadata import MediaMetadata
 
 import tests.utils
 from tilia.requests import Post, post, stop_listening_to_all, stop_serving_all, Get
 from tilia.file.tilia_file import TiliaFile
 from tilia.file.file_manager import FileManager
 from unittest.mock import patch
+from tilia.ui.windows.metadata import MediaMetadataWindow
 
 from tilia.ui.actions import TiliaAction
 
@@ -93,27 +94,45 @@ def test_file_not_modified_after_open(self, tilia):
         assert not tilia.file_manager.is_file_modified(tilia.file_manager.file.__dict__)
 
     def test_metadata_edit_fields(self, tilia):
-        original = list(tilia.file_manager.file.media_metadata)
-        fields = list(tilia.file_manager.file.media_metadata)
+        def get_displayed_list(input: list[str]) -> list[str]:
+            output = []
+            for item in input:
+                if (
+                    item
+                    not in MediaMetadataWindow.SEPARATE_WINDOW_FIELDS
+                    + list(MediaMetadataWindow.READ_ONLY_FIELDS)
+                    + MediaMetadataWindow.PLAYBACK_TIMES
+                ):
+                    output.append(item)
+            return output
+
+        original = get_displayed_list(tilia.file_manager.file.media_metadata)
+        fields = get_displayed_list(tilia.file_manager.file.media_metadata)
         fields.insert(2, "newfield")
         post(Post.METADATA_UPDATE_FIELDS, fields)
-        assert list(tilia.file_manager.file.media_metadata)[2] == "newfield"
+        assert (
+            get_displayed_list(tilia.file_manager.file.media_metadata)[2] == "newfield"
+        )
 
         fields.pop(2)
         post(Post.METADATA_UPDATE_FIELDS, fields)
-        assert list(tilia.file_manager.file.media_metadata)[2] != "newfield"
-        assert list(tilia.file_manager.file.media_metadata) == original
+        assert (
+            get_displayed_list(tilia.file_manager.file.media_metadata)[2] != "newfield"
+        )
+        assert get_displayed_list(tilia.file_manager.file.media_metadata) == original
 
     def test_metadata_not_duplicated_required_fields(self, tilia):
         original = list(tilia.file_manager.file.media_metadata)
         duplicate = list(tilia.file_manager.file.media_metadata) + ["title"]
         post(Post.METADATA_UPDATE_FIELDS, duplicate)
         assert list(tilia.file_manager.file.media_metadata) == original
-    
+
     def test_metadata_delete_fields(self, tilia):
         empty_list = []
         post(Post.METADATA_UPDATE_FIELDS, empty_list)
-        assert list(tilia.file_manager.file.media_metadata) == list(tilia.file_manager.file.media_metadata.REQUIRED_FIELDS)
+        assert list(tilia.file_manager.file.media_metadata) == list(
+            tilia.file_manager.file.media_metadata.REQUIRED_FIELDS
+        )
 
     def test_metadata_title_stays_on_top(self, tilia):
         not_so_empty_list = ["newfield"]