Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1496: CinemachineDeoccluder was causing a pop when OnTargetObjectWarp… #884

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Jul 14, 2023

Purpose of this PR

CMCL-1496

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@glabute glabute changed the title CMCL-1496: CinemachineCollider was causing a pop when OnTargetObjectWarp… CMCL-1496: CinemachineDeoccluder was causing a pop when OnTargetObjectWarp… Jul 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (42e06d9) 21.04% compared to head (225dbef) 21.04%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   21.04%   21.04%   -0.01%     
==========================================
  Files         244      244              
  Lines       27431    27435       +4     
==========================================
  Hits         5774     5774              
- Misses      21657    21661       +4     
Impacted Files Coverage Δ
...achine/Runtime/Behaviours/CinemachineDeoccluder.cs 44.77% <0.00%> (-0.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glabute glabute merged commit f48c32f into main Jul 14, 2023
2 checks passed
@glabute glabute deleted the dev/deoccluder-pop branch July 14, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants