Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCL-1496: CinemachineDeoccluder was causing a pop when OnTargetObjectWarp… #884

Merged
merged 1 commit into from
Jul 14, 2023
Merged

CMCL-1496: CinemachineDeoccluder was causing a pop when OnTargetObjectWarp… #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.cinemachine/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Bugfix: Deceleration at the end of axis range was too aggressive.
- Bugfix: Orbital recentering should not be forced when transitioning to a camera.
- Bugfix: InheritPosition takes the actual camera position, so it works consistently if transitioning mid-blend.
- Bugfix: CinemachineDeoccluder was causing a pop when OnTargetObjectWarped was called.
- Added Recentering Target to OrbitalFollow. Recentering is now possible with Lazy Follow
- Deoccluder accommodates camera radius in all modes.
- StateDrivenCamera: child camera enabled status and priority are now taken into account when choosing the current active camera.
Expand Down
8 changes: 8 additions & 0 deletions com.unity.cinemachine/Runtime/Behaviours/CinemachineDeoccluder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,14 @@ public override float GetMaxDampTime()
: 0;
}

/// <inheritdoc />
public override void OnTargetObjectWarped(
CinemachineVirtualCameraBase vcam, Transform target, Vector3 positionDelta)
{
var extra = GetExtraState<VcamExtraState>(vcam);
extra.PreviousCameraPosition += positionDelta;
}

/// <summary>
/// Callback to do the collision resolution and shot evaluation
/// </summary>
Expand Down
Loading