This PR improves the primary interface support in the client library #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface This gives more flexibility as all the consumers doesn't have to be added when the object is created.
… primary interface This includes: * ProgramStateMessage *ErrorCodeMessage *KeyMessage *RuntimeExceptionMessage *TextMessage *RobotModeData Added constructor to robot message class
Updated abstract primary consumer with the new packages. The primary consumer logs relevant information to the shell. It also adds support for calibration check and feedback on script execution.
|
Any update on this? |
|
Any plans to merge this into main? |
|
Thanks for asking. Yes, but as you see we still missing some test to cover this work before it is ready to be merge. |
This was referenced May 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big acknowledgement should be given to @fmauch and @urmarp as they have build the foundation for this PR in #26 and #137.
I have tried to address the most important issues with the primary interface as it is today based on the work from #26 and #137, but without including all the changes from the PRs. This means that I have added more feedback when you send script commands to the robot and we also report if there is an error in the script send to the robot. Furthermore information received over the primary interface is logged in the shell.
Unfortunately I haven't had the time to add tests for the changes and this should definitely be done before merging.