Fix bug arraying errors

VGirol · Sep 27, 2019 · e8ac0f2 · e8ac0f2
1 parent c64c819
commit e8ac0f2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/Factory/DocumentFactory.php b/src/Factory/DocumentFactory.php
@@ -33,7 +33,12 @@ public function toArray(): array
             $json[Members::LINKS] = $this->links;
         }
         if (isset($this->errors)) {
-            $json[Members::ERRORS] = $this->errors;
+            $json[Members::ERRORS] = array_map(
+                function ($error) {
+                    return $error->toArray();
+                },
+                $this->errors
+            );
         }
         if ($this->dataHasBeenSet()) {
             $json[Members::DATA] = ($this->data === null) ? null : $this->data->toArray();

diff --git a/tests/Factory/DocumentFactoryTest.php b/tests/Factory/DocumentFactoryTest.php
@@ -4,6 +4,7 @@
 
 use PHPUnit\Framework\Assert as PHPUnit;
 use VGirol\JsonApiFaker\Factory\DocumentFactory;
+use VGirol\JsonApiFaker\Factory\ErrorFactory;
 use VGirol\JsonApiFaker\Factory\JsonapiFactory;
 use VGirol\JsonApiFaker\Factory\RelationshipFactory;
 use VGirol\JsonApiFaker\Factory\ResourceIdentifierFactory;
@@ -63,11 +64,9 @@ public function toArrayWithErrors()
             'self' => 'url'
         ];
         $jsonapi = (new JsonapiFactory)->setVersion('test');
+        $error = (new ErrorFactory)->setId('errorId')->set('code', 'secret');
         $errors = [
-            [
-                'id' => 'errorId',
-                'code' => 'secret'
-            ]
+            $error->toArray()
         ];
 
         $expected = [
@@ -83,7 +82,7 @@ public function toArrayWithErrors()
         $factory->setMeta($meta)
             ->setLinks($links)
             ->setJsonapi($jsonapi)
-            ->setErrors($errors);
+            ->addError($error);
 
         $result = $factory->toArray();