Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

689: translations not generated for choice list used with search() #690

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

lindsay-stevens
Copy link
Contributor

  • existing test case search_and_select didn't cover the multi-language case, which requires that itext is emitted for the inline selects.
  • approach and details described in Survey._redirect_is_search_itext.

Closes #689

Why is this the best possible solution? Were any other approaches considered?

What are the regression risks?

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run nosetests and verified all tests pass
  • run black pyxform tests to format code
  • verified that any code or assets from external sources are properly credited in comments

- existing test case search_and_select didn't cover the multi-language
  case, which requires that itext is emitted for the inline selects.
- approach and details described in Survey._redirect_is_search_itext.
| | select_one c2 | q2 | Question 2 | Chose 2 | |
| choices | | | | |
| | list_name | name | label::en | label::fr |
| | c1 | na | la-e | la-f |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The item list for a select with search() isn't actually a true item list, it's used to configure the columns used in the attached file. A more realistic example would be the one I had in the test in the issue: a single element with a name of something like id, a label::en of something like label_en and a label::fr of label_fr. It doesn't particularly matter for testing purposes but could be confusing to come back to.

@lognaturel
Copy link
Contributor

Thanks for this. This makes me kind of wish we weren't as obsessed with keeping old forms working but I continue to think it's important for our users.

Forgive me -- I'm going to go ahead and merge even though you marked this as draft! I have one suggestion for the tests that I'll do a follow-up PR for. I'd really like to put this release behind us and I think this is a very pragmatic approach and is easy to figure out with the comment.

@lognaturel lognaturel marked this pull request as ready for review January 26, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations not generated for choice list used with search()
2 participants