Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra prerequisite from makefile rules in programming guide and examples #1883

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Oct 24, 2024

Change Makefile rules in programming_examples and programming_guide from this:

run: ${targetname}.exe build/final.xclbin build/insts.txt

to this:

run: ${targetname}.exe build/final.xclbin

Because build/insts.txt is never the target of a rule and is produced by the xclbin target. The real reason for this PR is that for some tests this was preventing make -j run from working in a clean directory.

@fifield fifield changed the title Rm insts Remove extra prerequisite from makefile rules in programming guide and examples Oct 24, 2024
@fifield fifield added this pull request to the merge queue Oct 24, 2024
Merged via the queue into Xilinx:main with commit 8329b6c Oct 24, 2024
50 checks passed
@fifield fifield deleted the rm_insts branch October 24, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants